Comment 1 for bug 989741

Revision history for this message
Eike Thaden (ethaden) wrote :

I think that the code used to prepare the input for the libkcddb discid calculation is flawed at least for Musicbrainz lookups. The patch adds detection of data tracks which are then ignored when preparing the list of track offsets. The behavior for audio discs without data tracks remains unchanged. I currently don't know whether or not the modified discid calculation for discs with data tracks will work for freedb lookups, too. Strange: The discid calculation algorithm presented on the Musicbrainz web seite (http://musicbrainz.org/doc/Disc_ID_Calculation) did not yield any results for my test audio disc when using their proposed method for calculation of the lead out track offset. Instead, the lookup was successful if all data tracks are ignored and the track offset calculation is left unchanged (using method "cdda_track_firstsector").