Comment 17 for bug 1945838

Revision history for this message
Adam Williamson (awilliamson) wrote :

Yeah, I backported the fix to Fedora and it works. I'd just wonder if we want a check whether there are any tags after we read them all (to avoid any avoidable errors if a non-audio file is added), and maybe if we should add the `if taglist` check to the `for audio_stream in info.get_audio_streams():` block too, just to be super safe - theoretically, if we somehow get a null taglist from `audio_stream.get_tags()` there, we'd hit an exception trying to call `taglist.foreach` on it and fail to parse the file, *even if we already got valid tags from the global info*.