When encoding fails, original file is still deleted

[Ivo Anjo]

While I was trying to debug https://bugs.launchpad.net/soundconverter/+bug/913204 I noticed that if you have "Delete original file" in the preferences, the original file is deleted even when encoding fails.

This happens for instance with this file
http://thesixteendigital.com.s3.amazonaws.com/testfiles/Hallelujah%20lossless.m4a
from
http://www.thesixteendigital.com/testfiles/
that triggers the gstreamer bug.

This happens with latest 2.1.1 version.

[Michael Schwendt (mschwendt)]

How does encoding fail? Or decoding?

[Ivo Anjo (knuckles)]

Erm. I don't understand the question?

I try to convert the test file to flac, select delete original, and it fails (due to a gstreamer bug, and gstreamer spits and error), and SoundConverter still deletes the original file.

Besides the supplied test files, there are lots of error logs for the other bug, that triggered this one, as I linked above.

[Michael Schwendt (mschwendt)]

Be a little bit more positive, please.

The test files are useless, if conversion is successful. And here it is successful with Fedora 19 and a heavily patched SoundConverter 2.0.4 as well as a pristine 2.1.1. So, I couldn't reproduce the issue.

In other words, you run into a GStreamer error, which isn't recognized somehow. Interesting. That alters the test-case, however.

[Ivo Anjo (knuckles)]

I'm sorry if you don't think I'm being positive, and I'm glad to see that the bugfix for the gstreamer bug I reported was already deployed in Fedora, but I don't know what further information I can provide to help debug this.

The test sound was the same I supplied in the gstreamer bug report https://bugzilla.gnome.org/show_bug.cgi?id=705018 .

[GautierPortet (kassoulet)]

I reproduce the problem with Fedora 19 and SoundConverter 2.1.1.

Of course, it's impossible :)

[GautierPortet (kassoulet)]

Oops :)

[GautierPortet (kassoulet)]

https://github.com/kassoulet/soundconverter/commit/dd52bf44117691c288ad4958e23cbcfca1a1a383

[GautierPortet (kassoulet)]

Good catch Ivo!