Comment 6 for bug 1831910

Revision history for this message
Simon Davy (bloodearnest) wrote : Re: [Bug 1831910] Re: \r in metrics API output

On Wed, 12 Jun 2019 at 14:05, William Grant <email address hidden> wrote:

> It's most likely that the bad character in the channel is coming from a
> client calling the refresh API with it.
>

Right, that would make sense. I haven't found anything in the snapstats
code which would explain it, the strings are never parsed, they're opaque.

I would suspect the same for the channel "3.0" and "/stable/ubuntu-18.10",
"/stable/ubuntu-19.04" channel names.

So in that case, the proper fix is channel name validation/sanitization in
snapdevicegw, I think?

> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1831910
>
> Title:
> \r in metrics API output
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/snapstore/+bug/1831910/+subscriptions
>

--
Simon