Comment 8 for bug 1698068

Revision history for this message
Stéphane Graber (stgraber) wrote :

Just a quick update on this one, the current support for overrides hasn't really helped all that much.

The issue we ran into is that `override-pull` runs before all pull actions and `override-build` runs after all pull actions.

A git cherry-pick would happen in between the git pull action but before the plugin's own pull.
This is particularly important for things like the Go plugin where a missing cherry-pick can cause its own pull to fail.

Currently our options are to either re-implement the entirety of "pull" for both the source and plugin in use or to ship a modified version of the plugin (which is what we're doing currently).

Also, we like things being declarative so having a "source-cherrypick" or something along those lines which can handle this cleanly would allow for additional validation and a cleaner workflow.