nodejs plugin needs to be able to build using gulpfiles

Bug #1575880 reported by Sergio Schvezov on 2016-04-27
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Wishlist
Sergio Schvezov
snapcraft (Ubuntu)
Undecided
Unassigned
Xenial
Wishlist
Unassigned
Yakkety
Wishlist
Unassigned

Bug Description

Gulp needs to be supported as a build driver

[Impact]

 * It is not easy to make a snap from a project that uses gulp.

[Test Case]

 * define a snapcraft.yaml for a project that uses gulp.
 * run snapcraft, install the snap and execute it.

[Regression Potential]

 * None, this is a new plugin.

Changed in snapcraft:
importance: Undecided → Wishlist
assignee: nobody → Sergio Schvezov (sergiusens)
milestone: none → 2.9

I don't know the specifics, but you might get a more general solution by supporting npm-scripts https://docs.npmjs.com/misc/scripts

Sergio Schvezov (sergiusens) wrote :

Yeah, I read all about http://blog.keithcirkel.co.uk/why-we-should-stop-using-grunt/ and much more; sadly two important electron based apps use gulp and grunt; those are vscode and atom respectively. I have it working for gulp (was able to build a snap with vscode already).

I do agree that gulp and grunt and not that useful though ;-)
And we already support npm scripts :-)

Changed in snapcraft:
status: New → In Progress
Changed in snapcraft:
milestone: 2.9 → 2.10
Changed in snapcraft:
milestone: 2.10 → 2.11
Kyle Fazzari (kyrofa) wrote :

Note that this is needed for webdm as well.

My 2 pennies worth: This should be a standalone gulp plugin. I don't think that the nodejs plugin should understand other js build systems except through npm scripts (which means they'd be local, not global modules); for gulp, grunt, webpack, etc, etc, when they're expected to be run outside of `npm run` (ie. global npm modules) that should happen via a purpose built plugin.

Sergio Schvezov (sergiusens) wrote :

El 09/06/16 a las 04:23, Stephen Stewart escribió:
> My 2 pennies worth: This should be a standalone gulp plugin. I don't
> think that the nodejs plugin should understand other js build systems
> except through npm scripts (which means they'd be local, not global
> modules); for gulp, grunt, webpack, etc, etc, when they're expected to
> be run outside of `npm run` (ie. global npm modules) that should happen
> via a purpose built plugin.
>

Thanks, this confirms the path we are taking :-)

I was reluctant to add it to the nodejs plugin for another reason which
was parameter overload.

I will make sure I ping you for a review once I have that extra hour to
push a PR for this ;-)

Changed in snapcraft:
status: In Progress → Fix Committed
Leo Arias (elopio) on 2016-06-27
description: updated

Hello Sergio, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Leo Arias (elopio) wrote :

Tested in an up-to-date xenial:

- enabled -proposed
- update snapcraft to 2.12
- got sergio's project from integration_tests/snaps/simple-gulp
- snapcraft

I reported a related bug in https://bugs.launchpad.net/snapcraft/+bug/1596762, no blocker.

I'm going to mark this as verifyied, thanks Steve!

tags: added: verification-done
removed: verification-needed
Changed in snapcraft:
status: Fix Committed → Fix Released

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

affects: Ubuntu Xenial → snapcraft (Ubuntu Xenial)
Changed in snapcraft (Ubuntu Xenial):
importance: Undecided → Wishlist
status: New → Fix Released
Changed in snapcraft (Ubuntu Yakkety):
status: New → Fix Released
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers