Comment 0 for bug 231017
Revision history for this message
| Daniel Nouri (daniel.nouri) wrote Preview newsletter view does not render collector items | #0 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
This view is in dancing.
It does not render items that are in the collector, only the context object. Compare with the message sending preview that *does* take those items into account.
Also, but less important:
- The preview view makes the assumption that messages will be sent in HTML format. Naturally, this won't be always true. Maybe we should rename it (and relabel in the UI) to HTMLPreviewView, and not make it available if there's no 'html' composer available. Although the composer doesn't even come into play here when rendering, it would make sense to me not to display "preview as HTML" when the message is in fact not going to be sent this way. (Renderers for SMS might display the items completely different, giving a false preview.)
- The preview form as it is could be merged with sendnewsletter.py.