senlin node-create ｓpecify the cluster

[chenyb4]

Use "senlin node-create" specify the cluster, the cluster has max_size, the node don't create succeed and return error, but the node status always INIT status.

Example:

The node create:

# senlin node-create -p profile_nova -c cluster_002 node_001
WARNING (shell) "senlin node-create" is deprecated and will be removed by Apr 2017, please use "openstack cluster node create" instead.
+---------------+--------------------------------------+
| Property | Value |
+---------------+--------------------------------------+
| cluster_id | cbab4413-b828-4fae-8c21-e145569472de |
| created_at | - |
| data | {} |
| dependents | {} |
| details | - |
| domain_id | - |
| id | f1e6d2ff-9a7c-4c1a-866d-9938acede06f |
| index | 10 |
| init_at | 2017-08-02T08:23:39Z |
| location | - |
| metadata | {} |
| name | node_001 |
| physical_id | - |
| profile_id | 8c7ca125-3986-4464-880a-29eaf8a5ec7b |
| profile_name | profile_nova |
| project_id | 631b9209a992429fb70909d810a4d3b9 |
| role | |
| status | INIT |
| status_reason | Initializing |
| updated_at | - |
| user_id | 0ed165520f9b443ca9040e4e1f44d7f0 |
+---------------+--------------------------------------+

The engine log:

e4e1f44d7f0 631b9209a992429fb70909d810a4d3b9 - - -] Node create action queued: fcf7f8e0-b43e-471d-aa33-5614e5a94659.
2017-08-02 04:23:40.157 6727 INFO senlin.engine.event [req-62b59039-7e56-4f53-8b1e-0081be4e9cf4 0ed165520f9b443ca9040e4e1f44d7f0 631b9209a992429fb70909d810a4d3b9 - - -] node_001 [f1e6d2ff] NODE_CREATE - start: None
2017-08-02 04:23:40.790 6727 ERROR senlin.engine.event [req-62b59039-7e56-4f53-8b1e-0081be4e9cf4 0ed165520f9b443ca9040e4e1f44d7f0 631b9209a992429fb70909d810a4d3b9 - - -] node_001 [f1e6d2ff] NODE_CREATE - error: The target capacity (3) is greater than the cluster's max_size (2).

The node status:
[root@ocata-senlin ~(keystone_admin)]# senlin node-list
WARNING (shell) "senlin node-list" is deprecated and will be removed by Apr 2017, please use "openstack cluster node list" instead.
+----------+-------------------+-------+--------+------------+-------------+--------------+----------------------+----------------------+
| id | name | index | status | cluster_id | physical_id | profile_name | created_at | updated_at |
+----------+-------------------+-------+--------+------------+-------------+--------------+----------------------+----------------------+
| 3e057382 | node-cbab4413-008 | 8 | ACTIVE | cbab4413 | 019de57d | profile_nova | 2017-08-02T08:22:29Z | 2017-08-02T08:22:29Z |
| 4cf368d3 | node-cbab4413-009 | 9 | ACTIVE | cbab4413 | f18e425c | profile_nova | 2017-08-02T08:22:26Z | 2017-08-02T08:22:26Z |
| f1e6d2ff | node_001 | 10 | INIT | | | profile_nova | - | - |
+----------+-------------------+-------+--------+------------+-------------+--------------+----------------------+----------------------+

The right way, must set node status before return error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/490798

[chenyb4 (chenyb4)]

An other bug has fix.
https://bugs.launchpad.net/senlin/+bug/1746913

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Erik Olof Gunnar Andersson <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/senlin/+/490798