Disable_doc_values property in plugin code doesn't work

[Lei Zhang]

In authoring plugin doc, disable_doc_values property is documented, by override the property one can control whether a plugin uses doc_value in its entire mapping. http://docs.openstack.org/developer/searchlight/authoring-plugins.html#doc-values

But this property doesn't work now, seems we don't consider this property when generating plugin mappings in get_full_mapping method, https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/base.py#L446

[Lei Zhang (lei-a-zhang)]

We have exposed mapping_use_doc_values in configuration to control whether plugins use doc values. Is disable_doc_values property still needed?

[Steve McLellan (sjmc7)]

You're right, disable_doc_values shouldn't be used. A plugin could override the mapping_use_doc_values property if it wanted to forcibly disable doc_values for some reason.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329161

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329161
Committed: https://git.openstack.org/cgit/openstack/searchlight/commit/?id=33066df7cab3cb6e72de885e0ae19668a3fa2210
Submitter: Jenkins
Branch: master

commit 33066df7cab3cb6e72de885e0ae19668a3fa2210
Author: Steve McLellan <email address hidden>
Date: Mon Jun 13 14:30:42 2016 -0500

    Correct doc_values info in authoring plugins docs

    disable_doc_values no longer exists; corrects documentation to the
    correct property name.

    Change-Id: Id5b9f5a07072ceb364fd289fd4ffb9ee86007dc2
    Closes-Bug: #1579986

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/searchlight 1.0.0.0b2 development milestone.