Comment 11 for bug 714731

Revision history for this message
Louis Simard (louis-simard-deactivatedaccount) wrote :

Thanks for the submission. :)

The code looks sound, and correctly replaces the removed code in repairStyle. The tainting of attributes is a good way to avoid running repairStyle on children of an element for properties that shouldn't be checked anymore.

The unit tests look sound, correctly testing for both the removal and non-removal of default and non-default values on parents and children.

I'll run the full tests, make sure they render right with and without --disable-style-to-xml and that they don't crash or hang Scour; if so, your patches are good to go as is.