Comment 47 for bug 313202

Revision history for this message
Rongcui Dong (rongcuid) wrote :

Attached is the Milestone 1 patch with test cases. I reused tests from my feature branch, but simply asserted that defining routines will always fail.

However:

* Currently the test fixture isn't great at adding support on `:fails-on platform`, because I just asserted error
** I'll probably make the `(eval '(define...` changes in the development branch as well
* Error thrown is a SIMPLE-ERROR. I looked at CL's standard error types and didn't find a suitable one. Any suggestions?

Also, is `format-patch` the recommended way to submit patches? I grouped all of my commits into a single file, but not sure if I should do it.

The patch should be mergeable if there there are no problem.