Contribs need to be fixed. If it turns out lots of loops like this exist in the wild, then the change should be reconsidered. What percentage of eg. Quicklisp libraries still compile with this change?
Commit message: the first line should be a one-liner describing the change. The rest of the message should describe why & how. At minimum a reference to this bug, but preferably a bit more.
It is also nice to mention the affected operators in CAPS, so that searching commit logs is easier.
While this may seem like a tiny change that doesn't need much explanation, code like loop.lisp is touched seldom enough that no-one is intimately familiar with it -- which makes commit log explanations important when trying to figure things out a few years down the road.
The patch needs to include the test-case.
Contribs need to be fixed. If it turns out lots of loops like this exist in the wild, then the change should be reconsidered. What percentage of eg. Quicklisp libraries still compile with this change?
Commit message: the first line should be a one-liner describing the change. The rest of the message should describe why & how. At minimum a reference to this bug, but preferably a bit more.
It is also nice to mention the affected operators in CAPS, so that searching commit logs is easier.
This is a good read: http:// who-t.blogspot. com/2009/ 12/on-commit- messages. html
While this may seem like a tiny change that doesn't need much explanation, code like loop.lisp is touched seldom enough that no-one is intimately familiar with it -- which makes commit log explanations important when trying to figure things out a few years down the road.