Comment 23 for bug 1956852

Revision history for this message
alexis rivera (riveraah) wrote :

I'm working on modifying the unit tests that failed. My approach to get the tests to work in general was to replace the hard coded "/" and "/tmp" with *current-directory*. By default, Termux doesn't give permisions to "/". In addition, "/tmp" doesn't exist.

The tests OPENDIR.1 and READDIR.1 worked when I replaced "/" directory for *current-directory*. Is it ok to make this change? This change should work in general so I don't have to add conditional compilation statements.

I tried to something similar for MKSTEMP.NULL-TERMINATE by changing
(default (make-pathname :directory '(:absolute "tmp")))
to
(default (make-pathname :directory '(:relative "tmp")))

and the last line of the test from
  t "/tmp/mkstemp-1")
to
  t "tmp/mkstemp-1")

But that didn't work. I'm trying to get this one to work.

This test seems to be creating a temporary directory of the form
#P"/tmp/mkstemp-1.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxXXXXXX"

Is the last line of code of the test the expected value? Shouldn't the expected value be that form? ie.
  t "tmp/mkstemp-1.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxXXXXXX")

The reason that I'm hesitant to put conditional compilation statements is because termux is a hybrid platform; almost like linux but not quite. I don't know which conditions define termux exclusively. #-android and #-arm?

I will appreciate your suggestions. (I'm new to lisp, this is a good learning experience)