Comment 7 for bug 1503496

Revision history for this message
Jan Moringen (scymtym) wrote :

> How may I amend the proposed patch to make it acceptable?

I cannot promise that addressing these issues will get the patch accepted, but from previous discussions, I remember the following two points

1) Looking at the patch, rpg, stassats and me wondered why the added docstring bit was conditionalized but the added code wasn't.

2) If possible when relying only on guaranteed-to-be-available windows programs, adding a test that exercises the new behavior would be good.

Thanks for your patience.