SBCL

  1. Bug #1162301
  2. Comment #3

Comment 3 for bug 1162301

Revision history for this message
Jan Moringen (scymtym) wrote :

Thanks for the review. Updated patch is attached.

> I'd personally prefer if SB-SEQUENCE:EMPTYP returned a boolean rather than a generalised boolean, but that's really not major.

Done.

> We usually refer the launchpad ticket directly in test cases.

I changed the patch to reference the ticket in NEWS and WITH-TEST.

I did not reference the bug in the test case because it tests multiple things. Now the test case has the function, tested aspect and the bug in its name.

> Otherwise, it looks good, except that I have no clue on format trickery (:

I left the changed format string and review question in the patch, but maybe it can be committed without that part.