GET /jobs/{id} returns credentials

[Matthew Farrellee]

similar to https://bugs.launchpad.net/savanna/+bug/1272322

the credentials used to access the job data are readily available in the representation of the job transmitted from the service

NOTE - the python-savannaclient filters out the credentials before displaying them, that code can be removed when this is fixed.

[Andrew Lazarev (alazarev)]

>NOTE - the python-savannaclient filters out the credentials before displaying them, that code can be removed when this is fixed.

I think that code can be removed even before this is fixed. Client can always request job binaries via REST. Having code preventing that in client is strange.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82863

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82863
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=4da5dbf735165bc568c7e6b2b54de61cd250c03e
Submitter: Jenkins
Branch: master

commit 4da5dbf735165bc568c7e6b2b54de61cd250c03e
Author: Trevor McKay <email address hidden>
Date: Tue Mar 25 12:35:40 2014 -0400

    Filter credentials in jobs returned from REST api

    The 'mains' and 'libs' elements of a Job contain references
    to JobBinary objects, which can contain credentials in the
    'extra' field. Filter 'extra' from 'mains' and 'libs' when
    returning a wrapped Job object.

    Closes-Bug: #1272452
    Change-Id: Ieccadbbda1f081595374469cb938b7bffbc08e17