GET /job-binaries/{id} returns credentials

Bug #1272322 reported by Matthew Farrellee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
High
Trevor McKay

Bug Description

the credentials used to access the job binaries are readily available in the representation of the job-binary transmitted from the service

Changed in savanna:
importance: Undecided → High
milestone: none → icehouse-3
status: New → Triaged
assignee: nobody → Matthew Farrellee (mattf)
Revision history for this message
Matthew Farrellee (mattf) wrote :

NOTE - the python-savannaclient filters out the credentials before displaying them, that code can be removed when this is fixed.

Revision history for this message
Andrew Lazarev (alazarev) wrote :

>NOTE - the python-savannaclient filters out the credentials before displaying them, that code can be removed when this is fixed.

I think that code can be removed even before this is fixed. Client can always request job binaries via REST. Having code preventing that in client is strange.

Revision history for this message
Matthew Farrellee (mattf) wrote :

i may be the assignee for this eventually, but right now anyone should feel free to fix this

Changed in savanna:
assignee: Matthew Farrellee (mattf) → nobody
Changed in savanna:
assignee: nobody → Trevor McKay (tmckay)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to savanna (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73652

Changed in savanna:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to savanna (master)

Reviewed: https://review.openstack.org/73652
Committed: https://git.openstack.org/cgit/openstack/savanna/commit/?id=21b76890887c4997191b197988b70602b9b58a2d
Submitter: Jenkins
Branch: master

commit 21b76890887c4997191b197988b70602b9b58a2d
Author: Trevor McKay <email address hidden>
Date: Fri Feb 14 11:45:46 2014 -0500

    Filter credentials when returning job binaries through REST api

    The 'extra' field for job binaries is used to store credentials
    for accessing job binaries. Modify the JobBinary resource to
    specify 'extra' as a filtered field.

    Closes-bug: #1272322
    Change-Id: I92c01bd8015e6e515081f83faa186de004a35a39

Changed in savanna:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in savanna:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in sahara:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.