Comment 3 for bug 1389034

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to satori (master)

Reviewed: https://review.openstack.org/132721
Committed: https://git.openstack.org/cgit/stackforge/satori/commit/?id=dea382bae1cd043189589c0f7d4c20b4b6725ab5
Submitter: Jenkins
Branch: master

commit dea382bae1cd043189589c0f7d4c20b4b6725ab5
Author: Samuel Stavinoha <email address hidden>
Date: Tue Nov 4 20:18:53 2014 +0000

    interpret stderr and raise custom exceptions

    1. Detects failed authentication message from Windows systems
        and raises SatoriSMBAuthenticationException
    2. Detects error message stating that the user has been locked
        out of a Windows system and raises SatoriSMBLockoutException
    3. Detects error message stating shared access flags are
        incompatible on a Windows system and raises
        SatoriSMBFileSharingException

    Consolidates (DRY) the logic which listens to command output in
    smb.py so that the custom Exceptions mentioned above can be raised
    if any of the known error output is encountered.

    Unchanged: A non-zero exit status with an unknown error message
                raises a SubprocessError including that error message.

    Previously, all error messages corresponding to non-zero exit codes
    were "unknown".

    Closes-Bug: #1389034
    Change-Id: I157adfe9034177f7975473ff96f29fc17c6ad12b