Comment 16 for bug 977232

Hi Andrew, hi Sebastian,

I have updated the debian packaging repository of sakura with this
patch (thanks Sebastian) and prepared 3.0.3-3 packages.

Andrew, since I am also in the Uploaders field I can easily upload
this version, and push also a tag to the debian sakura.git.
Please let me know *soon* what your plans are, otherwise I will upload
rather sooner than later, maybe already tomorrow.

On So, 29 Apr 2012, Sebastian Reichel wrote:
> 1. It does lstat(file, &sb) before file has been filled with "/proc/<pid>/cwd", so it does lstat on NULL
> 2. It should do stat() instead of lstat(), since we are interested in the size of the path and not the size of the directory, which is 0
> 3. file must be free'd if lstat() fails
> 4. file must be free'd if size check fails
>
> So the patch introduces 2 errors breaking the code for sure and two
> potential memory leaks.
>
> Andrew Starr-Bochicchio, you should review patches before applying them.
>
> David Gómez, I guess the updated patch should go upstream. Using the
> actual path size is a cleaner approach, than using MAX_PATH and is POSIX
> compatible.
>
> [0] http://patch-
> tracker.debian.org/patch/series/view/sakura/2.4.2-4/fix_FTBFS4Hurd.patch
>
> -- Sebastian

Best wishes

Norbert
------------------------------------------------------------------------
Norbert Preining preining@{jaist.ac.jp, logic.at, debian.org}
JAIST, Japan TeX Live & Debian Developer
DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 B094
------------------------------------------------------------------------
I teleported home one night
With Ron and Sid and Meg.
Ron stole Meggie's heart away
And I got Sidney's leg.
                 --- A poem about matter transference beams.
                 --- Douglas Adams, The Hitchhikers Guide to the Galaxy