Comment 1 for bug 1496023
Revision history for this message
| Didier Barvaux (didier-barvaux) wrote | #1 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Klaus,
You're right, once more. The case with unchanged SACK option is not handled correctly. Thank you for the report!
However, I'm afraid that your fix proposal is not reliable. If discriminator is 0, you doesn't record anything into the struct d_tcp_opt_ctxt, so you keep the old values. By chance the old values seem to be the values of the previous SACK option, so it gives the good result. I would prefer to record an indication that the SACK option shall be retrieved from context, and then during the decoding phase retrieve the values from context. Some other options are implemented this way when static values are not transmitted. I'll implement something this way asap.
Regards,
Didier