Comment 52 for bug 493797

Revision history for this message
Johannes Wettinger (jojow) wrote :

Now some feedback on the blueprint itself. :-)

1) I suggest to move the repository link (UI prototypes etc.) into the summary of the blueprint, because this is some static additional information which doesn't belong to the specification itself.

2) For the "REQUIREMENTS & SPECIFICATION" chapter I think it would be better to summarize the target as well as the requirements shortly; otherwise you always have to go through the whole discussion in order to get some basic information.

3) You don't have to link to the FR bug report because the blueprint is already linked to it. ;-)

4) For the "DESIGN & TECHNICAL SOLUTION" chapter we should definitely add some more information about the implementation details, e.g.:
----
The whole assistant dialog will be re-implemented. After removing the class 'org.revager.gui.dialogs.AssistantDialog', we are going to create a new package called 'org.revager.gui.dialogs.assistant_dialog'. The package will contain the following classes:

AssistantDialog (extends AbstractDialog) - the assistant dialog itself which contains one of the following panels
FirstScreenPanel (extends AbstractDialogPanel) - the first screen (see prototype)
OpenReviewPanel (extends AbstractDialogPanel) - the open review screen (see prototype)
AddAttendeePanel (extends AbstractDialogPanel) - the add attendee screen (see prototype)

The AbstractDialogPanel contains the following property 'private AbstractDialog parent' as well as the following constructor and method

public AbstractDialogPanel(AbstractDialog parent) { super(); this.parent = parent; }

public void setHint(String hintText) { parent.setMessage(hintText) }

and will be located inside the 'org.revager.gui' package. By this strategy we can access the description text area inside the dialog itself.

Inside the AssistantDialog class there is one private property for each "screen class".
----

What do you think? ;-)