Align API implementation with specifcation
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| neutron |
Fix Released
|
Critical
|
Salvatore Orlando | ||
| quantum (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
There are currently several parts of the API implementation that are not aligned with the specification.
This happened as the specification was updated while the API was being implemented, and therefore the API code now does not reflect the specification.
These issues came out while developing code for API unit tests, and Somik has done a great job in pointing them out here:
https:/
Fixing this issue involves both reviewing the current specification and updating the code. We should strive to comply as much as possible with standards adopted in the Openstack API; also we need to provide full specification for format of request/responses object, both in JSON and XML format; moreover, we probably need another round of review at the status codes. As far as code is concerned, we need to make sure that it implements exactly what is stated on the specification.
Related branches
- dan wendlandt: Approve
- Somik Behera: Approve (netstack-core)
- Tyler Smith: Approve
-
Diff: 1449 lines (+501/-259)21 files modifiedetc/quantum.conf (+1/-1)
quantum/api/__init__.py (+9/-3)
quantum/api/api_common.py (+9/-18)
quantum/api/attachments.py (+86/-0)
quantum/api/faults.py (+0/-17)
quantum/api/networks.py (+34/-43)
quantum/api/ports.py (+63/-84)
quantum/api/versions.py (+2/-2)
quantum/api/views/attachments.py (+37/-0)
quantum/api/views/networks.py (+9/-10)
quantum/api/views/ports.py (+6/-14)
quantum/cli.py (+11/-10)
quantum/client.py (+2/-5)
quantum/common/exceptions.py (+0/-10)
quantum/common/wsgi.py (+10/-4)
quantum/db/api.py (+8/-1)
quantum/db/models.py (+2/-1)
quantum/plugins/SamplePlugin.py (+2/-2)
tests/unit/test_api.py (+151/-15)
tests/unit/test_clientlib.py (+1/-1)
tests/unit/testlib_api.py (+58/-18)
| Changed in quantum: | |
| assignee: | nobody → Salvatore Orlando (salvatore-orlando) |
| Changed in quantum: | |
| importance: | Undecided → Critical |
| Changed in quantum: | |
| status: | New → In Progress |
| Changed in quantum: | |
| milestone: | none → diablo-4 |
| Changed in quantum: | |
| status: | In Progress → Fix Committed |
| Changed in quantum: | |
| status: | Fix Committed → Fix Released |
| Changed in quantum (Ubuntu): | |
| status: | New → Fix Released |
