Touch point size sent to clients is much smaller under Unity8/QtMir than when run under Mir demo servers

[Daniel van Vugt]

Touch point size sent to clients is much smaller under Unity8/QtMir than when run under Mir demo servers.

I noticed when running mir_demo_client_fingerpaint under Unity8 that the touch point size is microscopic (almost invisible on arale). Running the same client under a Mir demo server, the touch point size is much bigger and more visible.

A quick grep of the qtmir source code seems to show that it ignores and/or doesn't yet implement "mir_touch_axis_size".

[Daniel van Vugt (vanvugt)]

See related bug 1354254.

[Andreas Pokorny (andreas-pokorny)]

Why do we provide touch contact size as a single value? This is not a value that we get directly from the device, instead it is calculated from major/minor.. which we also provide.. and which are well defined (but mostly badly scaled).

On that topic since at least nexus 10 provides an orientation (and I believe another of our supported devices does so too).. I would suggest to deprecate size and add orientation.

[Daniel van Vugt (vanvugt)]

Hmm it seems QtMir has hardcoded a touch point size of zero :P

        mir::events::add_touch(*ev, id, action, tooltype,
                               touchPoint.pos().x(), touchPoint.pos().y(),
                               touchPoint.pressure(),
                               touchPoint.rect().width(),
                               touchPoint.rect().height(),
                               0 /* size */);

Trivial mistake.