Comment 9 for bug 958415
Revision history for this message
| Adam Reichold (adamreichold) wrote Re: Enhancement for Find | #9 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Thank you for being thorough. I run the program from the source code directory all the time, so I will hopefully notice any problems with that.
It is hard for me to interpret the GDB output with the exact revision number you were running. (Problematically enough I am still treating the trunk branch like my personal one, so I push changes to frequently. I will try to change this in the future.)
The problem of hanging is that if a search is running a the GUI thread tries to access the result list (e.g. to clear the results when closing the search bar), it will block until that search is over. (So the real problem is that searches can't currently be canceled.)
I also agree that this was completely unrelated to the specific files. I really made some gross mistakes when calling into the GUI thread from the search thread. I am sorry for pushing the feature in such a rough state.
Nevertheless Benjamin Eltzner and I did some more testing and have now (trunk revision 75) hopefully found the biggest problems. It should also be a bit harder to bring the program down, as changes are ignored if a search is already running. (Maybe suboptimal, but again canceling seems to be the problem.) But if one types really slowly, the program will start to search for a single letter which will of course take a very long time. Do you think the timer should be remove so that a search has to be started using the return key manually?