Building of QPDFView w/o DBUS

[Silvan Scherrer]

Hey Adam,

as already talked via e-mail here is the bugreport.
QPDFView is not building anymore, if DBUS is disabled. Wit the below patch it builds again:

diff -Naur -x qpdfview.desktop E:\trees\qpdfview\trunk\..\vendor\current/sources/mainwindow.cpp E:\trees\qpdfview\trunk/sources/mainwindow.cpp
--- E:\trees\qpdfview\trunk\..\vendor\current/sources/mainwindow.cpp 2016-11-20 19:33:00.000000000 +0100
+++ E:\trees\qpdfview\trunk/sources/mainwindow.cpp 2016-11-23 13:52:40.000000000 +0100
@@ -1288,6 +1288,7 @@
         return;
     }

+#ifdef WITH_DBUS
     QScopedPointer< QDBusInterface > interface(MainWindowAdaptor::createInterface(instanceName));

     if(!interface->isValid())
@@ -1309,6 +1310,7 @@
     }

     interface->call("saveDatabase");
+#endif

     closeTab(tab);
 }

here is a seconf patch, which fixes a small issue in the german translation.

diff -Naur -x qpdfview.desktop E:\trees\qpdfview\trunk\..\vendor\current/translations/qpdfview_de.ts E:\trees\qpdfview\trunk/translations/qpdfview_de.ts
--- E:\trees\qpdfview\trunk\..\vendor\current/translations/qpdfview_de.ts 2016-11-20 19:33:00.000000000 +0100
+++ E:\trees\qpdfview\trunk/translations/qpdfview_de.ts 2016-11-23 14:22:04.000000000 +0100
@@ -674,7 +674,7 @@
     <message>
         <location filename="../sources/mainwindow.cpp" line="2026"/>
         <source>&lt;/ul&gt;&lt;p&gt;See &lt;a href=&quot;https://launchpad.net/qpdfview&quot;&gt;launchpad.net/qpdfview&lt;/a&gt; for more information.&lt;/p&gt;&lt;p&gt;&amp;copy; 2012-2016 The qpdfview developers&lt;/p&gt;</source>
- <translation type="unfinished">&lt;/ul&gt;&lt;p&gt;Siehe &lt;a href=&quot;https://launchpad.net/qpdfview&quot;&gt;launchpad.net/qpdfview&lt;/a&gt; f├╝r weitere Informationen.&lt;/p&gt;&lt;p&gt;&amp;copy; 2012-2015 Die qpdfview-Entwickler&lt;/p&gt; {2012-2016 ?}</translation>
+ <translation type="unfinished">&lt;/ul&gt;&lt;p&gt;Siehe &lt;a href=&quot;https://launchpad.net/qpdfview&quot;&gt;launchpad.net/qpdfview&lt;/a&gt; f├╝r weitere Informationen.&lt;/p&gt;&lt;p&gt;&amp;copy; 2012-2016 Die qpdfview-Entwickler&lt;/p&gt;</translation>
     </message>
     <message>
         <location filename="../sources/mainwindow.cpp" line="2907"/>

[Adam Reichold (adamreichold)]

Hello Silvan,

thanks for taking the time to report this! I committed a similar fix to qpdfview's trunk, including an error message on why move-to-instance does not work if D-Bus is disabled.

Best regards, Adam.

P.S.: The translation are collaboratively maintained at [1] and the above issue should then be fixed when I import updated translations from Launchpad.

[1] https://translations.launchpad.net/qpdfview/trunk/+pots/qpdfview