Comment 4 for bug 1463073

Revision history for this message
Dorian Scholz (dorianscholz) wrote :

Hey Adam,

this is a great improvement!
I've tested it in horizontal and vertical layout and it works great!
I was able to make the thumbnails not fit in the view though by resizing the dock really fast.
Not sure if this can be avoided easily, but it is more of a cosmetic problem, since resizing at normal speed works just fine.

One thing that is especially nice with your change is, it also "fixes" another issue that was bothering me before in the fixed size layout.
In documents with mixed landscape and portrait pages they were not all the same width in vertical (or height in horizontal) dock layout.
But rather had the fixed thumbnail size as height for portrait and as width for landscape pages, making the dock never fit them all perfectly...

Maybe you want to add this change to the fixed thumbnail size code as well?
I guess the problem is just the use on qMin in documentview.cpp:2531 compared to the if/else switch based on m_thumbnailsOrientation which you implemented in the dynamic scaling part.

Thanks again for this really fast fix!

Cheers,
Dorian