qpdfview

Bug #1267266
Comment #15

Comment 15 for bug 1267266

Revision history for this message

Razi Alavizadeh (srazi) wrote on 2014-09-08: Re: [Bug 1267266] Re: View List of Bookmarks and add Metadata to them

#15

Hello again,
Also on removing bookmark it should check if model's list of bookmark is
empty then it forgets path of the model.

Best Regards,
Razi.

2014-09-09 0:21 GMT+04:30 Seyyed Razi Alavizadeh <email address hidden>:

> Hello Adam,
> > I now refactored the bookmarks into a separate model class with central
> > registry using absolute file paths. Could you try to test whether I
> > broke compilation or functionality? Thanks!
> Edit bookmark duplicates bookmark.
>
> Best Regards,
> Razi.
>
> 2014-09-08 23:36 GMT+04:30 Adam Reichold <email address hidden>:
>
>> Hello again,
>>
>> Am 07.09.2014 um 22:00 schrieb S. Razi Alavizadeh:
>> > Hello Adam
>> >> thank you for your contribution. I merged after minimal changes:
>> >> * Some nit pickings like the placement of ampersands.
>> >> * One has to check the column count before using
>> QHeaderView::setSectionResizeMode in Qt5.
>> >
>> > Thanks for your points and also for improving my code. :-)
>> >
>> >> I just pushed trunk revision 1665 which extends the bookmarks with
>> > comment and modification date and time fields (bumping the bookmark
>> > format to v3) and adds a little dialog to edit these properties that is
>> > accessible via the context menu of the bookmarks dock. Please test and
>> > report your findings here.
>> >
>> > Great! I suggest that by using a delegete comment be visible under label
>> > of bookmark. (like attached screenshot by Aeou)
>> >
>> > Also there is a compile issue with MSVC++ that can be fixed by following
>> > patch:
>>
>> I now refactored the bookmarks into a separate model class with central
>> registry using absolute file paths. Could you try to test whether I
>> broke compilation or functionality? Thanks!
>>
>> Best regards, Adam.
>>
>> > === modified file sources/mainwindow.h
>> > --- sources/mainwindow.h 2014-09-07 16:15:24 +0000
>> > +++ sources/mainwindow.h 2014-09-07 19:27:39 +0000
>> > @@ -26,6 +26,7 @@
>> > #define MAINWINDOW_H
>> >
>> > #include <QMainWindow>
>> > +#include <QHash>
>> >
>> > #ifdef WITH_DBUS
>> >
>> > @@ -42,6 +43,7 @@
>> > class QStandardItemModel;
>> > class QTableView;
>> > class QWidgetAction;
>> > +class QDateTime;
>> >
>> > #include "global.h"
>> >
>> >
>> > Best Regards,
>> > Razi.
>> >
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1267266
>>
>> Title:
>> View List of Bookmarks and add Metadata to them
>>
>> Status in qpdfview:
>> Fix Committed
>>
>> Bug description:
>> Firstly, a huge thank you for this light PDF reader--I love it!
>>
>> However, a very important feature for me that this reader lacks is the
>> management of bookmarks. Specifically:
>>
>> -Support naming bookmarks
>> -Support adding a description to a bookmark
>> -Have a dock (like the Thumbnails and Outline) that lists all bookmarks
>> for the file, including page number, bookmark name and the truncated
>> description. Clicking on a bookmark in this list, takes you to the
>> bookmarked page.
>>
>> This is essential for instructional, academic and reference books--and
>> the like--where you have to navigate around the book often, unlike a
>> novel which you generally read back-to-front. Imagine having more than
>> 10 bookmarks, and trying to find a particular piece of information you
>> bookmarked; having only the page-number to go by is not enough so you
>> must keep in your head what each bookmark points to, and, when you
>> forget this, you have to jump between bookmarks until you find it.
>>
>> See attached a screenshot of this functionality in obsolete kpdf2
>> (Okular's predecessor).
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/qpdfview/+bug/1267266/+subscriptions
>>
>
>
>
> --
> Alavizadeh, Sayed Razi
> My Blog: http://pozh.org
> Saaghar (نرم‌افزار شعر): http://saaghar.pozh.org/
> Saaghar Fan Page: http://www.facebook.com/saaghar.p
> Saaghar Mailing List: http://groups.google.com/group/saaghar
>
>

--
Alavizadeh, Sayed Razi
My Blog: http://pozh.org
Saaghar (نرم‌افزار شعر): http://saaghar.pozh.org/
Saaghar Fan Page: http://www.facebook.com/saaghar.p
Saaghar Mailing List: http://groups.google.com/group/saaghar

Hello again,
Also on removing bookmark it should check if model's list of bookmark is
empty then it forgets path of the model.

Best Regards,
Razi.

2014-09-09 0:21 GMT+04:30 Seyyed Razi Alavizadeh <s.r.alavizadeh@gmail.com>:

> Hello Adam,
> > I now refactored the bookmarks into a separate model class with central
> > registry using absolute file paths. Could you try to test whether I
> > broke compilation or functionality? Thanks!
> Edit bookmark duplicates bookmark.
>
> Best Regards,
> Razi.
>
> 2014-09-08 23:36 GMT+04:30 Adam Reichold <adam.reichold@t-online.de>:
>
>> Hello again,
>>
>> Am 07.09.2014 um 22:00 schrieb S. Razi Alavizadeh:
>> > Hello Adam
>> >> thank you for your contribution. I merged after minimal changes:
>> >> * Some nit pickings like the placement of ampersands.
>> >> * One has to check the column count before using
>> QHeaderView::setSectionResizeMode in Qt5.
>> >
>> > Thanks for your points and also for improving my code. :-)
>> >
>> >> I just pushed trunk revision 1665 which extends the bookmarks with
>> > comment and modification date and time fields (bumping the bookmark
>> > format to v3) and adds a little dialog to edit these properties that is
>> > accessible via the context menu of the bookmarks dock. Please test and
>> > report your findings here.
>> >
>> > Great! I suggest that by using a delegete comment be visible under label
>> > of bookmark. (like attached screenshot by Aeou)
>> >
>> > Also there is a compile issue with MSVC++ that can be fixed by following
>> > patch:
>>
>> I now refactored the bookmarks into a separate model class with central
>> registry using absolute file paths. Could you try to test whether I
>> broke compilation or functionality? Thanks!
>>
>> Best regards, Adam.
>>
>> > === modified file sources/mainwindow.h
>> > --- sources/mainwindow.h      2014-09-07 16:15:24 +0000
>> > +++ sources/mainwindow.h      2014-09-07 19:27:39 +0000
>> > @@ -26,6 +26,7 @@
>> >  #define MAINWINDOW_H
>> >
>> >  #include <QMainWindow>
>> > +#include <QHash>
>> >
>> >  #ifdef WITH_DBUS
>> >
>> > @@ -42,6 +43,7 @@
>> >  class QStandardItemModel;
>> >  class QTableView;
>> >  class QWidgetAction;
>> > +class QDateTime;
>> >
>> >  #include "global.h"
>> >
>> >
>> > Best Regards,
>> > Razi.
>> >
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1267266
>>
>> Title:
>>   View List of Bookmarks and add Metadata to them
>>
>> Status in qpdfview:
>>   Fix Committed
>>
>> Bug description:
>>   Firstly, a huge thank you for this light PDF reader--I love it!
>>
>>   However, a very important feature for me that this reader lacks is the
>>   management of bookmarks. Specifically:
>>
>>   -Support naming bookmarks
>>   -Support adding a description to a bookmark
>>   -Have a dock (like the Thumbnails and Outline) that lists all bookmarks
>> for the file, including page number, bookmark name and the truncated
>> description. Clicking on a bookmark in this list, takes you to the
>> bookmarked page.
>>
>>   This is essential for instructional, academic and reference books--and
>>   the like--where you have to navigate around the book often, unlike a
>>   novel which you generally read back-to-front. Imagine having more than
>>   10 bookmarks, and trying to find a particular piece of information you
>>   bookmarked; having only the page-number to go by is not enough so you
>>   must keep in your head what each bookmark points to, and, when you
>>   forget this, you have to jump between bookmarks until you find it.
>>
>>   See attached a screenshot of this functionality in obsolete kpdf2
>>   (Okular's predecessor).
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/qpdfview/+bug/1267266/+subscriptions
>>
>
>
>
> --
> Alavizadeh, Sayed Razi
> My Blog: http://pozh.org
> Saaghar (نرم‌افزار شعر): http://saaghar.pozh.org/
> Saaghar Fan Page: http://www.facebook.com/saaghar.p
> Saaghar Mailing List: http://groups.google.com/group/saaghar
>
>

-- 
Alavizadeh, Sayed Razi
My Blog: http://pozh.org
Saaghar (نرم‌افزار شعر): http://saaghar.pozh.org/
Saaghar Fan Page: http://www.facebook.com/saaghar.p
Saaghar Mailing List: http://groups.google.com/group/saaghar