Comment 11 for bug 1267266

Revision history for this message
Razi Alavizadeh (srazi) wrote :

Hello Adam
> thank you for your contribution. I merged after minimal changes:
> * Some nit pickings like the placement of ampersands.
> * One has to check the column count before using QHeaderView::setSectionResizeMode in Qt5.

Thanks for your points and also for improving my code. :-)

> I just pushed trunk revision 1665 which extends the bookmarks with comment and modification date and time fields (bumping the bookmark format to v3) and adds a little dialog to edit these properties that is accessible via the context menu of the bookmarks dock. Please test and report your findings here.

Great! I suggest that by using a delegete comment be visible under label of bookmark. (like attached screenshot by Aeou)

Also there is a compile issue with MSVC++ that can be fixed by following patch:

=== modified file sources/mainwindow.h
--- sources/mainwindow.h 2014-09-07 16:15:24 +0000
+++ sources/mainwindow.h 2014-09-07 19:27:39 +0000
@@ -26,6 +26,7 @@
 #define MAINWINDOW_H

 #include <QMainWindow>
+#include <QHash>

 #ifdef WITH_DBUS

@@ -42,6 +43,7 @@
 class QStandardItemModel;
 class QTableView;
 class QWidgetAction;
+class QDateTime;

 #include "global.h"

Best Regards,
Razi.