Comment 11 for bug 1171820

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Ari,

Am 08.08.2013 06:42, schrieb Ari:
> Hello Adam,
>
> I was very glad to see your commit in my inbox and I now have the
> latest revision of qpdfview installed. The outline synchronization
> works great for me. I really like how the entries automatically
> expand to sub- entries when needed.

Thanks for testing this and reporting about your findings here.

> There are just two smaller graphical inconsistencies I think I
> found:
>
> 1. Only the chapter titles are highlighted right now. This looks a
> bit awkward, I think, and I'd prefer it if the page numbers were
> highlighted as well.

I fine-tuned the selection of the outline view to work on a per-row
basis which should fix this issue and also enable to jump to a page by
clicking on the second column. This was committed to trunk revision 1212.

> 2. The highlighting appears to take up the "inactive color" by
> default and only switches back to the active state when clicking
> on an entry. I think that the color state should only change when
> the whole window is focused/unfocused - similarly to the thumbnail
> highlighting.

In contrast to the thumbnails view, the drawing behaviour of the
outline view is determined by Qt's tree view component and its active
style. Hence this out of scope for qpdfview. (And for example,
currently running qpdfview under KDE 4.10 with openSUSE's default
theme, I don't see the described behaviour. As I said, this could very
well be style-dependent.)

> -----
>
> These are only my first impressions with this new feature. I will
> have to do some more in-depth testing with more convoluted PDFs to
> see how the synchronization performs in these cases. I'll make
> sure to keep you posted on my findings.

This would be rather welcome. Note one known limitation though: The
"synchronization" will only expand and highlight entries that have
exactly the right page number. I am not sure if I am willing to extend
 this to an implementation finding a real lower bound yet.

> Thanks again for taking the time to implement this!
>
> Cheers --Ari
>

Best regards, Adam.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQEcBAEBAgAGBQJSA9jGAAoJEPSSjE3STU34plcH/2+MWMbSuo+/a8tEruOGb3a9
F4dOw8qBVZF6vd8DwZVWPFeC8skYdFMsewxmMnBlm1VVBkz9lCC17s4B1piiF03t
c5cvsKC2y54gQSwVfwolN7dn6A/yQkqroAfO+4M3m0rDJYfivN8FpdGFBxsQF4d5
atrTk5c0CG+YkQRaKzJfymGHWH/0bHSWWRqSJMJqvEvdoVI5ox6Tm/K19Eu4rM99
R+MDufT2Vhpsmr6PML2dvoJx4S9QgVXQCkDKwmiKlE/gGQbqGfR6Jf1TDmzBND1i
2gIIJyae5s0VoUaWZ4uSC7ff/i3WKZkRWtjtcElBoHROlLVFlSEllG86JKThsno=
=e0bE
-----END PGP SIGNATURE-----