qpdfview

Bug #1028295
Comment #15

Comment 15 for bug 1028295

Revision history for this message

Adam Reichold (adamreichold) wrote on 2014-10-28: Re: [Bug 1028295] Re: Add extended search interface working across tabs

#15

Hello Amit,

Am 28.10.2014 um 06:46 schrieb Amit Keret:
> Adam and Razi,
>
> I'm so happy to see this feature implemented!
> The behavior is great, results appear fast and in an intuitive manner, I really like the way you coded this.
>
> After some playing around, a few notes:
> 1. Looks like the setting should be done differently, currently it reads as though there's a new separate dock just for this. Since this is an enhancement to an already existing dock, I think it should say something like "Enable extended search (restart required)".
> 2. ...and once it's enabled, I believe the default behavior change to searching all open documents (meaning - no need for shift-enter to make it happen).
> 3. Only mouse clicks make the viewport jump between results, it's not possible at the moment to use this feature with the keyboard. I would suggest making this feature work with the Up/Down keys and/or the standard "Find next" shortcut.
> 4. Small bug: Since the results can be lengthy now, I've moved the search dock to the side (combined with the Outline dock). Now, pressing Ctrl+F doesn't focus the search dock - it just opens in the background as another tab in the dock. I have to use the mouse to click the tab, and only then it's focused on the search term. Positioning the dock BELOW the Outline dock is a good workaround for now, though.

I made the search raise itself when search is activated and also
connected the activation signal of the tree view, so that you can
navigate the results using the arrow keys within the view and pressing
return.

I also changed the default search mode w.r.t. whether the extended dock
search dock is enabled. Note that we will probably make more adjustments
to the behavior of the user interface in any case, e.g. the cancel
button does not really work well with the extended search dock and we
will probably add a separate close button. So there is still some
optimization left to do anyway.

> Besides these, this implementation is EXACTLY what I meant for this to be!
> Really tremendous work, job well done!

Thank you for the praise.

Best regards, Adam.

Hello Amit,

Am 28.10.2014 um 06:46 schrieb Amit Keret:
> Adam and Razi,
> 
> I'm so happy to see this feature implemented!
> The behavior is great, results appear fast and in an intuitive manner, I really like the way you coded this.
> 
> After some playing around, a few notes:
> 1. Looks like the setting should be done differently, currently it reads as though there's a new separate dock just for this. Since this is an enhancement to an already existing dock, I think it should say something like "Enable extended search (restart required)".
> 2. ...and once it's enabled, I believe the default behavior change to searching all open documents (meaning - no need for shift-enter to make it happen).
> 3. Only mouse clicks make the viewport jump between results, it's not possible at the moment to use this feature with the keyboard. I would suggest making this feature work with the Up/Down keys and/or the standard "Find next" shortcut.
> 4. Small bug: Since the results can be lengthy now, I've moved the search dock to the side (combined with the Outline dock). Now, pressing Ctrl+F doesn't focus the search dock - it just opens in the background as another tab in the dock. I have to use the mouse to click the tab, and only then it's focused on the search term. Positioning the dock BELOW the Outline dock is a good workaround for now, though.

> Besides these, this implementation is EXACTLY what I meant for this to be!
> Really tremendous work, job well done!

Thank you for the praise.

Best regards, Adam.