QEMU

  1. Bug #739785
  2. Comment #47

Comment 47 for bug 739785

Revision history for this message
Peter Maydell (pmaydell) wrote : Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

Steve: there are a number of issues with that patch:
 * x86 cpu_set_tls() doesn't belong in linux-user/syscall.c (but it's not trivial to put it in target-i386 because it's calling do_set_thread_area())
 * it's not "obviously correct" and the author says it needs review, and I'd have to dig out info about this obscure corner of the x86 ABI/architecture
 * I'm pretty sure it's not the only thing needed for threading support on x86, so (until/unless I look much more closely at the whole area) I don't have much confidence that this patch is a coherent single part of the required work
 * there's no Signed-off-by: line from the author so it can't be committed as is

Hopefully somebody else on the list will have time to look properly at the patch; I'm afraid I don't expect to currently.