We don't use qemu internals from spice server context any more.
Thus we don't also need to grab the iothread mutex from spice
server context. And we don't have to temporarely release the
lock to avoid deadlocks. Drop all the calls.
spice: don't call displaystate callbacks from spice server context.
This patch moves the displaystate callback calls for setting the cursor
and the mouse pointer from spice server to qemu (iothread) context.
This allows us to simplify locking.
spice: don't create updates in spice server context.
This patch moves the creation of spice screen updates from the spice
server context to qemu iothread context (display refresh timer to be
exact). This way we avoid accessing qemu internals (display surface)
from spice thread context which in turn allows us to simplify locking.
Make spice dummy functions inline to fix calls not checking return values
qemu_spice_set_passwd() and qemu_spice_set_pw_expire() dummy functions
needs to be inline, in order to handle the case where they are called
without checking the return value.
So , git clone git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git
creates a directory allows to build tar ball for debian "qemu-kvm" packages ,
which work with no "QXL" patching at all.
Also in meantime git://git. kernel. org/pub/ scm/virt/ kvm/qemu- kvm.git
contains commits:-
commit 196a77842898921 7b82de042725dc8 eb29c8f8d8
Author: Gerd Hoffmann <email address hidden>
Date: Wed Apr 27 16:06:10 2011 +0200
spice: drop obsolete iothread locking
We don't use qemu internals from spice server context any more.
Thus we don't also need to grab the iothread mutex from spice
server context. And we don't have to temporarely release the
lock to avoid deadlocks. Drop all the calls.
Signed-off-by: Gerd Hoffmann <email address hidden>
commit 075360945860ad9 bdd491921954b38 3bf762b0e5
Author: Gerd Hoffmann <email address hidden>
Date: Wed Apr 27 15:50:32 2011 +0200
spice: don't call displaystate callbacks from spice server context.
This patch moves the displaystate callback calls for setting the cursor
and the mouse pointer from spice server to qemu (iothread) context.
This allows us to simplify locking.
Signed-off-by: Gerd Hoffmann <email address hidden>
commit e0c64d08d11736d cea7c5a6373e3e7 f62db51d9e
Author: Gerd Hoffmann <email address hidden>
Date: Wed Apr 27 15:21:51 2011 +0200
spice: don't create updates in spice server context.
This patch moves the creation of spice screen updates from the spice
server context to qemu iothread context (display refresh timer to be
exact). This way we avoid accessing qemu internals (display surface)
from spice thread context which in turn allows us to simplify locking.
Signed-off-by: Gerd Hoffmann <email address hidden>
commit 14da8345b2f7c21 bab20fd12b755a6 1d6277f171
Author: Jes Sorensen <email address hidden>
Date: Tue Feb 1 15:53:23 2011 +0100
Make spice dummy functions inline to fix calls not checking return values
qemu_ spice_set_ passwd( ) and qemu_spice_ set_pw_ expire( ) dummy functions
needs to be inline, in order to handle the case where they are called
without checking the return value.
Signed-off-by: Jes Sorensen <email address hidden>
Signed-off-by: Gerd Hoffmann <email address hidden>
So , git clone git://git. kernel. org/pub/ scm/virt/ kvm/qemu- kvm.git
creates a directory allows to build tar ball for debian "qemu-kvm" packages ,
which work with no "QXL" patching at all.