Comment 7 for bug 638955
Revision history for this message
| Edgar E. Iglesias (edgar-iglesias) wrote Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes) | #7 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
On Mon, Sep 20, 2010 at 10:50:40AM +0200, Kevin Wolf wrote:
> Am 19.09.2010 08:36, schrieb Stefan Hajnoczi:
> > On Sat, Sep 18, 2010 at 10:27 PM, Edgar E. Iglesias
> > <email address hidden> wrote:
> >> This doesn't look right. AFAIK, MAC's dont pad on receive.
> >
> > I agree. NICs that do padding will do it on transmit, not receive.
> > Anything coming in on the wire should already have the minimum length.
> >
> > In QEMU that isn't true today and that's why rtl8139, pcnet, and
> > ne2000 already do this same padding. This patch is the smallest
> > change to cover e1000.
>
> What's the reason that it isn't true in QEMU today? Shouldn't we fix
> these problems rather than making device emulations incorrect to
> compensate for it?
Yes we should, I agree.
Cheers