On 20/11/2020 08:17, Mark Cave-Ayland wrote:
> Commit ae5643ecc6 "hw/display/tcx: Allow 64-bit accesses to framebuffer stippler > and blitter" enabled 64-bit access for the TCX framebuffer stippler and blitter > but missed applying the change to one of the blitter MemoryRegions. > > Whilst the original change works for me on my local NetBSD test image, the latest > NetBSD ISO panics on startup without this fix. > > Signed-off-by: Mark Cave-Ayland <email address hidden> > Fixes: ae5643ecc6 ("hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter") > Buglink: https://bugs.launchpad.net/bugs/1892540 > --- > hw/display/tcx.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/display/tcx.c b/hw/display/tcx.c > index 878ecc8c50..3799d29b75 100644 > --- a/hw/display/tcx.c > +++ b/hw/display/tcx.c > @@ -649,10 +649,14 @@ static const MemoryRegionOps tcx_blit_ops = { > .read = tcx_blit_readl, > .write = tcx_blit_writel, > .endianness = DEVICE_NATIVE_ENDIAN, > - .valid = { > + .impl = { > .min_access_size = 4, > .max_access_size = 4, > }, > + .valid = { > + .min_access_size = 4, > + .max_access_size = 8, > + }, > }; > > static const MemoryRegionOps tcx_rblit_ops = {
Adding CC to qemu-stable so that this follow-up fix also gets applied to 5.1.1.
ATB,
Mark.
On 20/11/2020 08:17, Mark Cave-Ayland wrote:
> Commit ae5643ecc6 "hw/display/tcx: Allow 64-bit accesses to framebuffer stippler /bugs.launchpad .net/bugs/ 1892540 .3799d29b75 100644 NATIVE_ ENDIAN,
> and blitter" enabled 64-bit access for the TCX framebuffer stippler and blitter
> but missed applying the change to one of the blitter MemoryRegions.
>
> Whilst the original change works for me on my local NetBSD test image, the latest
> NetBSD ISO panics on startup without this fix.
>
> Signed-off-by: Mark Cave-Ayland <email address hidden>
> Fixes: ae5643ecc6 ("hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter")
> Buglink: https:/
> ---
> hw/display/tcx.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/tcx.c b/hw/display/tcx.c
> index 878ecc8c50.
> --- a/hw/display/tcx.c
> +++ b/hw/display/tcx.c
> @@ -649,10 +649,14 @@ static const MemoryRegionOps tcx_blit_ops = {
> .read = tcx_blit_readl,
> .write = tcx_blit_writel,
> .endianness = DEVICE_
> - .valid = {
> + .impl = {
> .min_access_size = 4,
> .max_access_size = 4,
> },
> + .valid = {
> + .min_access_size = 4,
> + .max_access_size = 8,
> + },
> };
>
> static const MemoryRegionOps tcx_rblit_ops = {
Adding CC to qemu-stable so that this follow-up fix also gets applied to 5.1.1.
ATB,
Mark.