Comment 2 for bug 1847440

On Thu, Oct 10, 2019 at 07:16:49AM -0000, Launchpad Bug Tracker wrote:
> You have been subscribed to a public bug by Satheesh Rajendran (sathnaga):
>
> PowerPC KVM Guest fails to boot on current qemu master, bad commit:
> e68cd0cb5cf49d334abe17231a1d2c28b846afa2
>
> Env:
> HW: IBM Power9
> Host Kernel: 5.4.0-rc2-00038-ge3280b54afed
> Guest Kernel: 4.13.9-300.fc27.ppc64le
> Qemu: https://github.com/qemu/qemu.git (master)
> Libvirt: 5.4.0
>
> Guest boot gets stuck:
> ...
> [ OK ] Mounted Kernel Configuration File System.
> [ 7.598740] virtio-pci 0000:00:01.0: enabling device (0000 -> 0003)
> [ 7.598828] virtio-pci 0000:00:01.0: virtio_pci: leaving for legacy driver
> [ 7.598957] virtio-pci 0000:00:02.0: enabling device (0000 -> 0003)
> [ 7.599017] virtio-pci 0000:00:02.0: virtio_pci: leaving for legacy driver
> [ 7.599123] virtio-pci 0000:00:04.0: enabling device (0000 -> 0003)
> [ 7.599182] virtio-pci 0000:00:04.0: virtio_pci: leaving for legacy driver
> [ 7.620620] synth uevent: /devices/vio: failed to send uevent
> [ 7.620624] vio vio: uevent: failed to send synthetic uevent
> [ OK ] Started udev Coldplug all Devices.
> [ 7.624559] audit: type=1130 audit(1570610300.990:5): pid=1 uid=0 auid=4294967295 ses=4294967295 subj=kernel msg='unit=systemd-udev-trigger comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success'
> [ OK ] Reached target System Initialization.
> [ OK ] Reached target Basic System.
> [ OK ] Reached target Remote File Systems (Pre).
> [ OK ] Reached target Remote File Systems.
> [ 7.642961] virtio_scsi: probe of virtio1 failed with error -22
> [ *** ] A start job is running for dev-disk…21b3519a80.device (14s / no limit)
> ...
>
> git bisect, yielded a bad commit
> [e68cd0cb5cf49d334abe17231a1d2c28b846afa2] spapr: Render full FDT on ibm
> ,client-architecture-support, reverting this commit boot the guest
> properly.
>
> git bisect start
> # good: [9e06029aea3b2eca1d5261352e695edc1e7d7b8b] Update version for v4.1.0 release
> git bisect good 9e06029aea3b2eca1d5261352e695edc1e7d7b8b
> # bad: [98b2e3c9ab3abfe476a2b02f8f51813edb90e72d] Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging
> git bisect bad 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d
> # good: [56e6250ede81b4e4b4ddb623874d6c3cdad4a96d] target/arm: Convert T16, nop hints
> git bisect good 56e6250ede81b4e4b4ddb623874d6c3cdad4a96d
> # good: [5d69cbdfdd5cd6dadc9f0c986899844a0e4de703] tests/tcg: target/s390x: Test MVC
> git bisect good 5d69cbdfdd5cd6dadc9f0c986899844a0e4de703
> # good: [88112488cf228df8b7588c8aa38e16ecd0dff48e] qapi: Make check_type()'s array case a bit more obvious
> git bisect good 88112488cf228df8b7588c8aa38e16ecd0dff48e
> # good: [972bd57689f1e11311d86b290134ea2ed9c7c11e] ppc/kvm: Skip writing DPDES back when in run time state
> git bisect good 972bd57689f1e11311d86b290134ea2ed9c7c11e
> # bad: [1aba8716c8335e88b8c358002a6e1ac89f7dd258] ppc/pnv: Remove the XICSFabric Interface from the POWER9 machine
> git bisect bad 1aba8716c8335e88b8c358002a6e1ac89f7dd258
> # bad: [00ed3da9b5c2e66e796a172df3e19545462b9c90] xics: Minor fixes for XICSFabric interface
> git bisect bad 00ed3da9b5c2e66e796a172df3e19545462b9c90
> # good: [33432d7737b53c92791f90ece5dbe3b7bb1c79f5] target/ppc: introduce set_dfp{64,128}() helper functions
> git bisect good 33432d7737b53c92791f90ece5dbe3b7bb1c79f5
> # good: [f6d4c423a222f02bfa84a49c3d306d7341ec9bab] target/ppc: remove unnecessary if() around calls to set_dfp{64,128}() in DFP macros
> git bisect good f6d4c423a222f02bfa84a49c3d306d7341ec9bab
> # bad: [e68cd0cb5cf49d334abe17231a1d2c28b846afa2] spapr: Render full FDT on ibm,client-architecture-support
> git bisect bad e68cd0cb5cf49d334abe17231a1d2c28b846afa2
> # good: [c4ec08ab70bab90685d1443d6da47293e3aa312a] spapr-pci: Stop providing assigned-addresses
> git bisect good c4ec08ab70bab90685d1443d6da47293e3aa312a
> # first bad commit: [e68cd0cb5cf49d334abe17231a1d2c28b846afa2]
> spapr: Render full FDT on ibm,client-architecture-support

Ah, dammit, I thought we'd fixed the problems with that patch :(.

>
> attached vmxml.
>
> qemu commandline:
> /home/sath/qemu/ppc64-softmmu/qemu-system-ppc64 -name guest=vm1,debug-threads=on -S -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain-19-vm1/master-key.aes -machine pseries-4.2,accel=kvm,usb=off,dump-guest-core=off -m 81920 -overcommit mem-lock=off -smp 512,sockets=1,cores=128,threads=4 -uuid fd4a5d54-0216-490e-82d2-1d4e89683b3d -display none -no-user-config -nodefaults -chardev socket,id=charmonitor,fd=24,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -boot strict=on -device qemu-xhci,id=usb,bus=pci.0,addr=0x3 -device virtio-scsi-pci,id=scsi0,bus=pci.0,addr=0x2 -drive file=/home/sath/tests/data/avocado-vt/images/jeos-27-ppc64le_vm1.qcow2,format=qcow2,if=none,id=drive-scsi0-0-0-0 -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,device_id=drive-scsi0-0-0-0,drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,bootindex=1 -netdev tap,fd=26,id=hostnet0,vhost=on,vhostfd=27 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:e6:df:24,bus=pci.0,addr=0x1 -chardev pty,id=charserial0 -device spapr-vty,chardev=charserial0,id=serial0,reg=0x30000000 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x4 -M pseries,ic-mode=xics -msg timestamp=on
>
> ** Affects: qemu
> Importance: Undecided
> Status: New
>
>
> ** Tags: kvm powerpcm qemu

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
    | _way_ _around_!
http://www.ozlabs.org/~dgibson