On 9/13/19 11:06 AM, Paolo Bonzini wrote:
> On 13/09/19 16:56, John Snow wrote:
>>
>>
>> On 9/13/19 4:33 AM, Alex Bennée wrote:
>>> Given we require python perhaps the simplest solution would be to re-
>>> write the tap-driver as a python script rather than adding another
>>> configure check?
>>
>> Seems a shame to need to after Paolo *just* introduced this perl script
>> late last year in 9df43317b82; it looks well-written as far as perl goes.
>
> Also because I didn't write it most of it (rather, it comes from
> Automake). The new dependency was even documented in the release notes:
>
> Running the QEMU testsuite now requires the Perl Test::Harness module.
> Most Linux and BSD distributions however install it by default
> together with Perl.
>
Yeah, let's just add a warning(?) to the configure check that you'll be
unable to run `make check` if you're missing this dependency. Easier
than re-writing.
On 9/13/19 11:06 AM, Paolo Bonzini wrote:
> On 13/09/19 16:56, John Snow wrote:
>>
>>
>> On 9/13/19 4:33 AM, Alex Bennée wrote:
>>> Given we require python perhaps the simplest solution would be to re-
>>> write the tap-driver as a python script rather than adding another
>>> configure check?
>>
>> Seems a shame to need to after Paolo *just* introduced this perl script
>> late last year in 9df43317b82; it looks well-written as far as perl goes.
>
> Also because I didn't write it most of it (rather, it comes from
> Automake). The new dependency was even documented in the release notes:
>
> Running the QEMU testsuite now requires the Perl Test::Harness module.
> Most Linux and BSD distributions however install it by default
> together with Perl.
>
Yeah, let's just add a warning(?) to the configure check that you'll be
unable to run `make check` if you're missing this dependency. Easier
than re-writing.
--js