Comment 16 for bug 1803872
Revision history for this message
| mst (mst-0) wrote Re: [PATCH v3 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation | #16 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
On Tue, Dec 18, 2018 at 06:51:17PM +0100, Philippe Mathieu-Daudé wrote:
> GCC 8 new warning prevents builds to success since quite some time.
> First report on the mailing list is in July 2018:
> https:/
>
> Various intents has been sent to fix this:
> - Incorrectly using g_strlcpy()
> https:/
> https:/
> - Using assert() and strpadcpy()
> https:/
> - Use #pragma GCC diagnostic ignored "-Wstringop-
> https:/
> - adding an inline wrapper with said pragma in there
> https:/
> - -Wno-stringop-
> https:/
> - Use the 'nonstring' attribute
> https:/
>
> This series add the QEMU_NONSTRING definition and use it.
>
> Regards,
>
> Phil.
Reviewed-by: Michael S. Tsirkin <email address hidden>
> Philippe Mathieu-Daudé (5):
> qemu/compiler: Define QEMU_NONSTRING
> block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays
> hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays
> migration: Use QEMU_NONSTRING for non NUL-terminated arrays
> migration: Use strnlen() for fixed-size string
>
> block/sheepdog.c | 2 +-
> hw/acpi/core.c | 8 ++++----
> include/
> include/
> migration/
> 5 files changed, 26 insertions(+), 11 deletions(-)
>
> --
> 2.17.2