Le 01/08/2018 à 00:57, umarcor a écrit :
> Alex, Laurent, I'm new to this management/development system. So, first
> off, thanks for working on this bug.
>
> I have a few (probably silly) questions:
>
> 1. What is 'the r-b' that Alex used in #14?
"Reviewed-By:", it's a tag I've sent in answer to his e-email to say
I've reviewed his patch, and it is good for me.
I didn't update the Changelog, but the fix is now committed. It will be
released soon (07/08 or 14/08). But you should test master now to check
the commit really fixes your bug.
> 3. Where did you push these commits to before they where merge in https://git.qemu.org/?p=qemu.git;a=summary? I cannot find your personal forks/branches. Are commits automatically created from the mailing list?
No, sub-system maintainers collect patches from the mailing list. They
create and send a pull request (in their own git repo) to the QEMU
maintainers, and he merges the patches into the master.
my git repo for linux-user pull request is
git://github.com/vivier/qemu.git, and generally I prepare my pull
request on linux-user-for-3.0 branch (the release number changes).
Le 01/08/2018 à 00:57, umarcor a écrit : development system. So, first
> Alex, Laurent, I'm new to this management/
> off, thanks for working on this bug.
>
> I have a few (probably silly) questions:
>
> 1. What is 'the r-b' that Alex used in #14?
"Reviewed-By:", it's a tag I've sent in answer to his e-email to say
I've reviewed his patch, and it is good for me.
> 2. When should I change the status of the bug? I can already see it in GitHub's mirror and in https:/ /git.qemu. org/?p= qemu.git; a=summary. But not in the Changelog: https:/ /wiki.qemu. org/ChangeLog/ 3.0#User- mode_emulation. I am not sure if it is in 'Fix Committed' or 'Fix Released' state.
I didn't update the Changelog, but the fix is now committed. It will be
released soon (07/08 or 14/08). But you should test master now to check
the commit really fixes your bug.
> 3. Where did you push these commits to before they where merge in https:/ /git.qemu. org/?p= qemu.git; a=summary? I cannot find your personal forks/branches. Are commits automatically created from the mailing list?
No, sub-system maintainers collect patches from the mailing list. They
create and send a pull request (in their own git repo) to the QEMU
maintainers, and he merges the patches into the master.
my git repo for linux-user pull request is com/vivier/ qemu.git, and generally I prepare my pull
git://github.
request on linux-user-for-3.0 branch (the release number changes).
Thanks,
Laurent