Comment 5 for bug 1759264
Revision history for this message
| Bastian Koppelmann (kbastian) wrote Re: [Qemu-devel] [Bug 1759264] Re: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0f7b58d
(Get the code!)
On 04/11/2018 01:01 PM, Alex Bennée wrote:
> Bastian Koppelmann <email address hidden> writes:
>
>> On 04/10/2018 10:07 PM, Alex Bennée wrote:
>>> Yeah it looks like it was missed, the round_to_uint code does it.
>>>
>>> Do you have a test case I can verify?
>>>
>>
>> For the NaN input 0xffffffff the expected result for the flags is that
>> flag_invalid is raised.
>>
>> I can provide you with some TriCore asm, but it is a bit of pain to get
>> the gnu assembler to build, since the public version is a decade old.
>
> I'll trust you if you send me a static binary for this particular
> verification ;-)
I set up a github repo with working binutils and the corresponding testcase:
https:/
The one caveat is, that we cannot produce any binaries with the TriCore
ISA > 1.3.
In this testcase the last ftoi instruction is supposed to raise the
invalid flag and return 0 since the input was NaN. We did that by only
checking for NaN if any flag was raised after ftoi, then do the NaN
check, and if positive, return 0.
Cheers,
Bastian