Comment 10 for bug 1658634

On 01/24/17 11:37, elmarco wrote:
> Hi
>
> On Tue, Jan 24, 2017 at 2:31 PM Gerd Hoffmann <email address hidden>
> wrote:
>
>> Only skip surface reallocation in case the old surface was created using
>> qemu_alloc_display (via qemu_create_displaysurface) too, otherwise we
>> might end up with a DisplaySurface with the wrong backing storage.
>>
>> Cc: <email address hidden>
>> Cc: Marc-André Lureau <email address hidden>
>> Fixes: cd958edb1fae85d0c7d1e1acbff82d22724e8d64
>> Signed-off-by: Gerd Hoffmann <email address hidden>
>> ---
>> ui/console.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ui/console.c b/ui/console.c
>> index b9575f2..67c65b7 100644
>> --- a/ui/console.c
>> +++ b/ui/console.c
>> @@ -2121,7 +2121,7 @@ void qemu_console_resize(QemuConsole *s, int width,
>> int height)
>>
>> assert(s->console_type == GRAPHIC_CONSOLE);
>>
>> - if (s->surface &&
>> + if (s->surface && (surface->flags & QEMU_ALLOCATED_FLAG) &&
>> pixman_image_get_width(s->surface->image) == width &&
>> pixman_image_get_height(s->surface->image) == height) {
>> return;
>>
>
> You are missing the 's->' !
>
> with that,
> Reviewed-by: Marc-André Lureau <email address hidden>

With that change:

Tested-by: Laszlo Ersek <email address hidden>

Also,

Cc: <email address hidden>

Thanks
Laszlo

> --
>> 1.8.3.1
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1658634
>>
>> Title:
>> Can't get correct display with latest QEMU and OVMF BIOS
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/qemu/+bug/1658634/+subscriptions
>>