Comment 4 for bug 1654137

Revision history for this message
elmarco (marcandre-lureau) wrote : Re: [Qemu-devel] [PATCH] char: fix ctrl-a b not working

On Tue, Jan 10, 2017 at 12:23 PM Paolo Bonzini <email address hidden> wrote:

On 10/01/2017 12:06, Marc-André Lureau wrote:
> CharDriverState.be should be updated to point to the current
> associated backend.
>
> Fix the regression introduced in the "mux" chardev from commit
> a4afa548fc6dd9842ed86639b4d37d4d1c4ad480.
>
> https://bugs.launchpad.net/bugs/1654137

Queued.

However, can you also simplify mux_chr_accept_input, mux_chr_can_read
and mux_chr_read to use d->be directly, with this change?

Yes, not a big improvement though. I'll consider it in the reactoring
series (https://github.com/elmarco/qemu/commits/chrfe)
--
Marc-André Lureau