b8eb5512fd8a115f164edbbe897cdf8884920ccb is the first bad commit
commit b8eb5512fd8a115f164edbbe897cdf8884920ccb
Author: Nadav Amit <email address hidden>
Date: Mon Apr 13 02:32:08 2015 +0300
target-i386: disable LINT0 after reset
Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone
and therefore this hack is no longer needed. Since it violates the
specifications, it is removed.
Signed-off-by: Nadav Amit <email address hidden>
Message-Id: <email address hidden>
Signed-off-by: Paolo Bonzini <email address hidden>
:040000 040000 a8ec76841b8d4e837c2cd0d0b82e08c0717a0ec6 d33744231c98c9f588cefbc92f416183f639706f M hw
apic_init_reset(dev);
-
- if (bsp) {
- /*
- * LINT0 delivery mode on CPU #0 is set to ExtInt at initialization
- * time typically by BIOS, so PIC interrupt can be delivered to the
- * processor when local APIC is enabled.
- */
- s->lvt[APIC_LVT_LINT0] = 0x700;
- }
}
/* This function is only used for old state version 1 and 2 */
I ran a bisect, and here's the result:
b8eb5512fd8a115 f164edbbe897cdf 8884920ccb is the first bad commit f164edbbe897cdf 8884920ccb
commit b8eb5512fd8a115
Author: Nadav Amit <email address hidden>
Date: Mon Apr 13 02:32:08 2015 +0300
target-i386: disable LINT0 after reset
Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone
and therefore this hack is no longer needed. Since it violates the
specifications, it is removed.
Signed-off-by: Nadav Amit <email address hidden>
Message-Id: <email address hidden>
Signed-off-by: Paolo Bonzini <email address hidden>
:040000 040000 a8ec76841b8d4e8 37c2cd0d0b82e08 c0717a0ec6 d33744231c98c9f 588cefbc92f4161 83f639706f M hw
$ git diff 7398dfc7799a500 97803db4796c7ed b6cd7d47a1 b8eb5512fd8a115 f164edbbe897cdf 8884920ccb
diff --git a/hw/intc/ apic_common. c b/hw/intc/ apic_common. c apic_common. c apic_common. c common( DeviceState *dev) >vapic_ base_update( s);
index 042e960..d38d24b 100644
--- a/hw/intc/
+++ b/hw/intc/
@@ -243,15 +243,6 @@ static void apic_reset_
info-
apic_ init_reset( dev); APIC_LVT_ LINT0] = 0x700;
-
- if (bsp) {
- /*
- * LINT0 delivery mode on CPU #0 is set to ExtInt at initialization
- * time typically by BIOS, so PIC interrupt can be delivered to the
- * processor when local APIC is enabled.
- */
- s->lvt[
- }
}
/* This function is only used for old state version 1 and 2 */
And then to confirm it:
git checkout v2.4.0 f164edbbe897cdf 8884920ccb
git revert b8eb5512fd8a115
And this build works. :)