Comment 6 for bug 970252

TI's TRMs always seem to provide only "example" revision numbers to demonstrate the format of the register -- they don't seem to bear any resemblance to the actual values in the hardware. I checked on a beagleboard which has an omap35xx, and it reports an MVR of 0x46.

So I guess we should:
 * leave the default revision property at 0x30 (which is probably still bogus for omap1/omap2 but doesn't change existing qemu behaviour)
 * have the omap34xx/35xx set the revision to 0x46
 * have omap36xx/37xx set revision to 0x52
 * enable new registers for revision 0x52
[your patch does most of that already, so I think it's just setting the revision to 0x46 for 34xx/35xx that's still todo.]

The thing I definitely need from you is a Signed-off-by: line for this patch (
http://lxr.linux.no/#linux+v3.3.1/Documentation/SubmittingPatches#L297 -- basically it's just certifying that you wrote it and have the right to submit it under the license that applies to QEMU).

Optional extras:
 * a git commit message
 * you'll find that your patch fails to pass ./scripts/checkpatch.pl -- all if statements need braces, even single line ones.
 * you've added a stray blank line to hw/pc.h

10MB is a bit big for an attachment I guess -- if you have a handy place to put it you could just provide a link to it. If you don't have a suitable server then go ahead and attach it to the bug.