Comment 20 for bug 814117

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 814117] Re: Problems with cyrillic cp1251 in internal diff (Failed to decode using charmap, falling back to latin1)

Vyacheslav Garashchenko пишет:
> Then I begin to preparing files to send to you, I find then this problem appear... It appear ONLY then file have some text in CP1251 encoding and some text in CP866. For me this appear because I was get some files from working project for testing the possibility of using bazaar in our work, and forget that files was converted to upload to server (SCO). But in real world this problem may appear very rarely - for example if in any programs will be appear texts in several encodings for several console encoding, which is "wrong style of programming"... SO this is a bug, but this bug may affected very small amount of peoples.
> This my fault - I was must to notice this at very beginning :(

I can confirm this behavior after looking at the real code. For mixed
content cp1251/cp866 python can't convert the content to unicode safely,
so we fallback to latin-1 encoding instead. I think we can try to
convert to unicode without falling back to latin-1 in such cases.

--
All the dude wanted was his rug back