qswitch: don't block directory picker while searching all branches in shared repo because it's slow
Bug #412058 reported by
Alexander Belchenko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
QBzr |
Fix Released
|
High
|
Javier Derderyan |
Bug Description
Subject says most of the actual report. Will be nice if collecting of branches will be done in background and just updating combobox (in the end or regularly) but do provide user ability to select another branch via Browse.
Changed in qbzr: | |
importance: | Undecided → High |
status: | New → Confirmed |
summary: |
- qswitch: don't block directory picker wile searching all branches in + qswitch: don't block directory picker while searching all branches in shared repo because it's slow |
Changed in qbzr: | |
assignee: | nobody → Javier Der Derian (javierder) |
Changed in qbzr: | |
milestone: | none → 0.14 |
status: | Confirmed → Fix Released |
To post a comment you must log in.
Gary, I need your opinion on this bug.
Recent changes fromn Javier discover that our throbber practice is not sufficient here. At all.
Now directory picker become visible right now but it's not available anyway until find_branches finished, because all this time window just not respond on user actions. So we should find another way to unblock UI.
Possible solution I see:
1) Put find_branches action into separate thread. I remember Lukas was always against threads in the QBzr.
2) Put find_branches action into subprocess, similar to what bzrtools' "branches" command do: emit found branch names to stdout and run subprocess output in the throbbered action.
3) Just disable find_branches and forgot about it?