Comment 5 for bug 394125

Revision history for this message
methane (songofacandy) wrote : Re: [Bug 394125] Re: SubProcessDialog doesn't work with PyQt 4.5

There are many conflicts. My patch is far from complete.

I'll make a branch and manage to resolve conflicts in below process.

1. rename method definitions.
  s/def close/def _close/
  s/def reject/def _reject/
  s/def accept/def _accept/
  s/def failed/def _failed/
  s/def finished/def _finished/

2. rename method calls conflicting against signals. (failed, finished)
  s/self.failed(/self._failed/
  s/self.finished(/self._finished/

3. resolve conflict between method and slots. (close, reject, accept)
This is difficult for me because I don't know "self.close()" is
calling Python method
or QWidget.close() slot.
I have idea that resolve it.

3.1 define fallback.
class _QBzrWindowBase:
    def _close(self): self.close()
    def _reject(self): self.reject()
    def _accept(self): self.accept()

3.2 rename all method calls

--
Naoki INADA <email address hidden>