Comment 3 for bug 381833
Revision history for this message
| Alexander Belchenko (bialix) wrote Re: [Bug 381833] Re: qcommit crashes on cancel | #3 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Gary van der Merwe пишет:
> On Thu, Jun 11, 2009 at 4:32 PM, Alexander Belchenko<email address hidden> wrote:
>> Craig, I guess you don't have write permissions to commit directly into
>> lp:bzr.
>
> Alex - The old code was trying to access the attribute 'control_files'
> which exists only for a local Repository objects, and not for
> RemoteRepository.
>
> I did some testing, and we only need to check that the branch is not
> locked, and not the repository. I'm not sure why I was checking if the
> Repository was locked before, but I'm sure this was incorrect.
I agree. Anyway this bug plunging the thoughts about another error
masked by the Traceback in this bug report. I.e. I'm sure Craig unable
to commit directly to lp:bzr. So his commit never succeed. Therefore on
exit qcommit will try to save commit message in branch.conf of lp:bzr.
But this operation should fail as well, because Craig has no permissions
to modify lp:bzr, and... we should get another error here actually,
I'm just can't predict which one. Real test needed!