Comment 7 for bug 295130

Hi Mark

I must sort out my EOL issues when it comes to bzr. (what IDE are you using? I'm currently using the pyDev eclipse plugin and i looked at Eric) Is there some way to configure EOL in bzr.

>>* The new 'if checkedFiles...' block looks suspect - if not self.pending_merges, it appears checkedFiles will always be zero, so therefore cause the checkbox? Also, see Python's pep8 - it should probably be checked_files.

I've noticed that too and fixed it in my bug fix branch: lp:~craighewetson/qbzr/trunk
I must look at the coding standards for python (coming from a java background I will have to watch myself)

>>FYI, "bzr [q]diff -rancestor:..\path-to-trunk" is what I'm using to preview the changes...
I was thinking of incorporating this into the qpush dialog as an action one can kick off. I think it would make sense if the user had the option to do this just before the final push.

>>* Comments "# FIXME need to find a way to extract this from the commit.py file" and " # FIXME get this from INFOWindow ui" - any thoughts on them?
Since i wanted to reuse a tab widget in the commit window, i tried to extract the set of widgets as a unit or blackbox. But the implementation wasn't encapsulated enough (made use of globals etc, that wasn't ). I think encapsulation must be in the back of the developers mind when making a gui component, since it could be reused in the future.

>>Why are they hard (ie, why not include a patch for them too?)
I've only started learning python about 2 weeks ago, and pyQT less than that. I only want to make that type of refactoring once I feel more comfortable with the languages.