Bug in the return of command 'volume qos create'

Bug #1656767 reported by jiahui.qiang on 2017-01-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
jiahui.qiang

Bug Description

When i use "volume qos create" command to create a qos for volume. I find a useless show in the item of specs:
➜ python-openstackclient git:(func-volume-qos) #openstack volume qos create hello
+----------+--------------------------------------+
| Field | Value |
+----------+--------------------------------------+
| consumer | both |
| id | 39a23ac7-b5e3-4a0a-8f03-38aa3cb4b1e8 |
| name | hello |
| specs | {} |
+----------+--------------------------------------+
➜ python-openstackclient git:(func-volume-qos) #openstack volume qos create hello1 --consumer front-end --property a=b
+----------+--------------------------------------+
| Field | Value |
+----------+--------------------------------------+
| consumer | front-end |
| id | 6190c068-d129-4dc8-b408-54760b6715d1 |
| name | hello1 |
| specs | {u'a': u'b'} |
+----------+--------------------------------------+
As is showed above,it will show useless { } in specs, when i set '--property' option.

Changed in python-openstackclient:
assignee: nobody → jiahui.qiang (jiahui.qiang)

Fix proposed to branch: master
Review: https://review.openstack.org/421065

Changed in python-openstackclient:
status: New → In Progress

Reviewed: https://review.openstack.org/421065
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=f353253122ca39aeb092656cea011a06e70103a4
Submitter: Jenkins
Branch: master

commit f353253122ca39aeb092656cea011a06e70103a4
Author: jiahui.qiang <email address hidden>
Date: Tue Jan 17 02:42:53 2017 +0800

    Error in the return of command 'volume qos create'

    This patch fixed a 'volume qos create' display mistake in argument
    of 'specs'[1]. For command such as:

     $ openstack volume qos create hello

     [1]https://bugs.launchpad.net/python-openstackclient/+bug/1656767
    Closes-bug:#1656767

    Change-Id: Ia9fce833d318d9b52b97c12cfb89e2d3c5465fbe

Changed in python-openstackclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-openstackclient 3.8.0 release.

Reviewed: https://review.openstack.org/428610
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=1be6c2d92fd83d9ba4a6813aa409cc888c0ce8fe
Submitter: Jenkins
Branch: master

commit 1be6c2d92fd83d9ba4a6813aa409cc888c0ce8fe
Author: Huanxuan Ao <email address hidden>
Date: Fri Feb 3 15:13:52 2017 +0800

    Fix properties format for volume qos in volume v1

    Notice that patch [1] fixed the error of properties
    format for volume qos in volume v2, but there is the
    same bug in volume v1, and the patch missed that, so
    fix the problem in v1 as well

    [1] https://review.openstack.org/#/c/421065/

    Partial-Bug: #1656767
    Change-Id: I156bf13d164dbd0d0a7ce394964176718c4ff0e5

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers