server boot with leading and trailing white spaces in name, displays weird error message

[Abhishek Kekane]

If you pass only white space or leading or trailing white spaces in name while creating instance then it raises 400 bad request exception, but error message is weird and pretty big.

Steps to reproduce:
-------------------

Create instance using boot command with leading or trailing white spaces.
$ nova boot --flavor <flavor-id> --image <image-id> "test "

ERROR (BadRequest): Invalid input for field/attribute name. Value: test . u'test ' does not match u'^(?![\\ \\\xa0\\\u1680\\\u180e\\\u2000\\\u2001\\\u2002\\\u2003\\\u2004\\\u2005\\\u2006\\\u2007\\\u2008\\\u2009\\\u200a\\\u202f\\\u205f\\\u3000])[\\ \\!\\"\\#\\$\\%\\&\\\'\\(\\)\\*\\+\\,\\-\\.\\/0123456789\\:\\;\\<\\=\\>\\?\\@ABCDEFGHIJKLMNOPQRSTUVWXYZ\\[\\\\\\]\\^\\_\\`abcdefghijklmnopqrstuvwxyz\\{\\|\\}\\~\\\xa0\\\xa1\\\xa2\\\xa3\\\xa4\\\xa5\\\xa6\\\xa7\\\xa8\\\xa9\\\xaa\\\xab\\\xac\\\xae\\\xaf\\\xb0\\\xb1\\\xb2\\\xb3\\\xb4\\\xb5\\\xb6\\\xb7\\\xb8\\\xb9\\\xba\\\xbb\\\xbc\\\xbd\\\xbe\\\xbf\\\xc0\\\xc1\\\xc2\\\xc3\\\xc4\\\xc5\\\xc6\\\xc7\\\xc8\\\xc9\\\xca\\\xcb\\\xcc\\\xcd\\\xce\\\xcf\\\xd0\\\xd1\\\xd2\\\xd3\\\xd4\\\xd5\\\xd6\\\xd7\\\xd8\\\xd9\\\xda\\\xdb\\\xdc\\\xdd\\\xde\\\xdf\\\xe0\\\xe1\\\xe2\\\xe3\\\xe4\\\xe5\\\xe6\\\xe7\\\xe8\\\xe9\\\xea\\\xeb\\\xec\\\xed\\\xee\\\xef\\\xf0\\\xf1\\\xf2\\\xf3\\\xf4\\\xf5\\\xf6\\\xf7\\\xf8\\\xf9\\\xfa\\\xfb\\\xfc\\\xfd\\\xfe\\\xff\\\u0100\\\u0101\\\u0102\\\u0103\\\u0104\\\u0105\\\u0106\\\u0107\\\u0108\\\u0109\\\u010a\\\u010b\\\u010c\\\u010d\\\u010e\\\u010f\\\u0110\\\u0111\\\u0112\\\u0113\\\u0114\\\u0115\\\u0116\\\u0117\\\u0118\\\u0119\\\u011a\\\u011b\\\u011c\\\u011d\\\u011e\\\u011f\\\u0120\\\u0121\\\u0122\\\u0123\\\u0124\\\u0125\\\u0126\\\u0127\\\u0128\\\u0129\\\u012a\\\u012b\\\u012c\\\u012d\\\u012e\\\u012f\\\u0130\\\u0131\\\u0132\\\u0133\\\u0134\\\u0135\\\u0136\\\u0137\\\u0138\\\u0139\\\u013a\\\u013b\\\u013c\\\u013d\\\u013e\\\u013f\\\u0140\\\u0141\\\u0142\\\u0143\\\u0144\\\u0145\\\u0146\\\u0147\\\u0148\\\u0149\\\u014a\\\u014b\\\u014c\\\u014d\\\u014e\\\u014f\\\u0150\\\u0151\\\u0152\\\u0153\\\u0154\\\u0155\\\u0156\\\u0157\\\u0158\\\u0159\\\u015a\\\u015b\\\u015c\\\u015d\\\u015e\\\u015f\\\u0160\\\u0161\\\u0162\\\u0163\\\u0164\\\u0165\\\u0166\\\u0167\\\u0168\\\u0169\\\u016a\\\u016b\\\u016c\\\u016d\\\u016e\\\u016f\\\u0170\\\u0171\\\u0172\\\u0173\\\u0174\\\u0175\\\u0176\\\u0177\\\u0178\\\u0179\\\u017a\\\u017b\\\u017c\\\u017d\\\u017e\\\u017f\\\u0180\\\u0181\\\u0182\\\u0183\\\u0184\\\u0185\\\u0186\\\u0187\\\u0188\\\u0189\\\u018a\\\u018b\\\u018c\\\u018d\\\u018e\\\u018f\\\u0190\\\u0191\\\u0192\\\u0193\\\u0194\\\u0195\\\u0196\\\u0197\\\u0198\\\u0199\\\u019a\\\u019b\\\u019c\\\u019d\\\u019e\\\u019f\\\u01a0\\\u01a1\\\u01a2\\\u01a3\\\u01a4\\\u01a5\\\u01a6\\\u01a7\\\u01a8\\\u01a9\\\u01aa\\\u01ab\\\u01ac\\\u01ad\\\u01ae\\\u01af\\\u01b0\\\u01b1\\\u01b2\\\u01b3\\\u01b4\\\u01b5\\\u01b6\\\u01b7\\\u01b8\\\u01b9\\\u01ba\\\u01bb\\\u01bc\\\u01bd\\\u01be\\\u01bf\\\u01c0\\\u01c1\\\u01c2\\\u01c3\\\u01c4\\\u01c5\\\u01c6\\\u01c7\\\u01c8\\\u01c9\\\u01ca\\\u01cb\\\u01cc\\\u01cd\\\u01ce\\\u01cf\\\u01d0\\\u01d1\\\u01d2\\\u01d3\\\u01d4\\\u01d5\\\u01d6\\\u01d7\\\u01d8\\\u01d9\\\u01da\\\u01db\\\u01dc\\\u01dd\\\u01de\\\u01df\\\u01e0\\\u01e1\\\u01e2\\\u01e3\\\u01e4\\\u01e5\\\u01e6\\\u01e7\\\u01e8\\\u01e9\\\u01ea\\\u01eb\\\u01ec\\\u01ed\\\u01ee\\\u01ef\\\u01f0\\\u01f1\\\u01f2\\\u01f3\\\u01f4\\\u01f5\\\u01f6\\\u01f7\\\u01f8\\\u01f9\\\u01fa\\\u01fb\\\u01fc\\\u01fd\\\u01fe\\\u01ff\\\u0200\\\u0201\\\u0202\\\u0203\\\u0204\\\u0205\\\u0206\\\u0207\\\u0208\\\u0209\\\u020a\\\u020b\\\u020c\\\u020d\\\u020e\\\u020f\\\u0210\\\u0211\\\u0212\\\u0213\\\u0214\\\u0215\\\u0216\\\u0217\\\u0218\\\u0219\\\u021a\\\u021b\\\u021c\\\u021d\\\u021e\\\u021f\\\u0220\\\u0221\\\u0222\\\u0223\\\u0224\\\u0225\\\u0226\\\u0227\\\u0228\\\u0229\\\u022a\\\u022b\\\u022c\\\u022d\\\u022e\\\u022f\\\u0230\\\u0231\\\u0232\\\u0233\\\u0234\\\u0235\\\u0236\\\u0237\\\u0238\\\u0239\\\u023a\\\u023b\\\u023c\\\u023d\\\u023e\\\u023f\\\u0240\\\u0241\\\u0242\\\u0243\\\u0244\\\u0245\\\u0246\\\u0247\\\u0248\\\u0249\\\u024a\\\u024b\\\u024c\\\u024d\\\u024e\\\u024f\\\u0250\\\u0251\\\u0252\\\u0253\\\u0254\\\u0255\\\u0256\\\u0257\\\u0258\\\u0259\\\u025a\\\u025b\\\u025c\\\u025d\\\u025e\\\u025f\\\u0260\\\u0261\\\u0262\\\u0263\\\u0264\\\u0265\\\u0266\\\u0267\\\u0268\\\u0269\\\u026a\\\u026b\\\u026c\\\u026d\\\u026e\\\u026f\\\u0270\\\u0271\\\u0272\\\u0273\\\u0274\\\u0275\\\u0276\\\u0277\\\u0278\\\u0279\\\u027a\\\u027b\\\u027c\\\u027d\\\u027e\\\u027f\\\u0280\\\u0281\\\u0282\\\u0283\\\u0284\\\u0285\\\u0286\\\u0287\\\u0288\\\u0289\\\u028a\\\u028b\\\u028c\\\u028d\\\u028e\\\u028f\\\u0290\\\u0291\\\u0292\\\u0293\\\u0294\\\u0295\\\u0296\\\u0297\\\u0298\\\u0299\\\u029a\\\u029b\\\u029c\\\u029d\\\u029e\\\u029f\\\u02a0\\\u02a1\\\u02a2\\\u02a3\\\u02a4\\\u02a5\\\u02a6\\\u02a7\\\u02a8\\\u02a9\\\u02aa\\\u02ab\\\u02ac\\\u02ad\\\u02ae\\\u02af\\\u02b0\\\u02b1\\\u02b2\\\u02b3\\\u02b4\\\u02b5\\\u02b6\\\u02b7\\\u02b8\\\u02b9\\\u02ba\\\u02bb\\\u02bc\\\u02bd\\\u02be\\\u02bf\\\u02c0\\\u02c1\\\u02c2\\\u02c3\\\u02c4\\\u02c5\\\u02c6\\\u02c7\\\u02c8\\\u02c9\\\u02ca\\\u02cb\\\u02cc\\\u02cd\\\u02ce\\\u02cf\\\u02d0\\\u02d1\\\u02d2\\\u02d3\\\u02d4\\\u02d5\\\u02d6\\\u02d7\\\u02d8\\\u02d9\\\u02da\\\u02db\\\u02dc\\\u02dd\\\u02de\\\u02df\\\u02e0\\\u02e1\\\u02e2\\\u02e3\\\u02e4\\\u02e5\\\u02e6\\\u02e7\\\u02e8\\\u02e9\\\u02ea\\\u02eb\\\u02ec\\\u02ed\\\u02ee\\\u02ef\\\u02f0\\\u02f1\\\u02f2\\\u02f3\\\u02f4\\\u02f5\\\u02f6\\\u02f7\\\u02f8\\\u02f9\\\u02fa\\\u02fb\\\u02fc\\\u02fd\\\u02fe\\\u02ff\\\u0300\\\u0301\\\u0302\\\u0303\\\u0304\\\u0305\\\u0306\\\u0307\\\u0308\\\u0309\\\u030a\\\u030b\\\u030c\\\u030d\\\u030e\\\u030f\\\u0310\\\u0311\\\u0312\\\u0313\\\u0314\\\u0315\\\u0316\\\u0317\\\u0318\\\u0319\\\u031a\\\u031b\\\u031c\\\u031d\\\u031e\\\u031f\\\u0320\\\u0321\\\u0322\\\u0323\\\u0324\\\u0325\\\u0326\\\u0327\\\u0328\\\u0329\\\u032a\\\u032b\\\u032c\\\u032d\\\u032e\\\u032f\\\u0330\\\u0331\\\u0332\\\u0333\\\u0334\\\u0335\\\u0336\\\u0337\\\u0338\\\u0339\\\u033a\\\u033b\\\u033c\\\u033d\\\u033e\\\u033f\\\u0340\\\u0341\\\u0342\\\u0343\\\u0344\\\u0345\\\u0346\\\u0347\\\u0348\\\u0349\\\u034a\\\u034b\\\u034c\\\u034d\\\u034e\\\u034f\\\u0350\\\u0351\\\u0352\\\u0353\\\u0354\\\u0355\\\u0356\\\u0357\\\u0358\\\u0359\\\u035a\\\u035b\\\u035c\\\u035d\\\u035e\\\u035f\\\u0360\\\u0361\\\u0362\\\u0363\\\u0364\\\u0365\\\u0366\\\u0367\\\u0368\\\u0369\\\u036a\\\u036b\\\u036c\\\u036d\\\u036e\\\u036f\\\u0370\\\u0371\\\u0372\\\u0373\\\u0374\\\u0375\\\u0376\\\u0377\\\u037a\\\u037b\\\u037c\\\u037d\\\u037e\\\u0384\\\u0385\\\u0386\\\u0387\\\u0388\\\u0389\\\u038a\\\u038c\\\u038e\\\u038f\\\u0390\\\u0391\\\u0392\\\u0393\\\u0394\\\u0395\\\u0396\\\u0397\\\u0398\\\u0399\\\u039a\\\u039b\\\u039c\\\u039d\\\u039e\\\u039f\\\u03a0\\\u03a1\\\u03a3\\\u03a4\\\u03a5\\\u03a6\\\u03a7\\\u03a8\\\u03a9\\\u03aa\\\u03ab\\\u03ac\\\u03ad\\\u03ae\\\u03af\\\u03b0\\\u03b1\\\u03b2\\\u03b3\\\u03b4\\\u03b5\\\u03b6\\\u03b7\\\u03b8\\\u03b9\\\u03ba\\\u03bb\\\u03bc\\\u03bd\\\u03be\\\u03bf\\\u03c0\\\u03c1\\\u03c2\\\u03c3\\\u03c4\\\u03c5\\\u03c6\\\u03c7\\\u03c8\\\u03c9\\\u03ca\\\u03cb\\\u03cc\\\u03cd\\\u03ce\\\u03cf\\\u03d0\\\u03d1\\\u03d2\\\u03d3\\\u03d4\\\u03d5\\\u03d6\\\u03d7\\\u03d8\\\u03d9\\\u03da\\\u03db\\\u03dc\\\u03dd\\\u03de\\\u03df\\\u03e0\\\u03e1\\\u03e2\\\u03e3\\\u03e4\\\u03e5\\\u03e6\\\u03e7\\\u03e8\\\u03e9\\\u03ea\\\u03eb\\\u03ec\\\u03ed\\\u03ee\\\u03ef\\\u03f0\\\u03f1\\\u03f2\\\u03f3\\\u03f4\\\u03f5\\\u03f6\\\u03f7\\\u03f8\\\u03f9\\\u03fa\\\u03fb\\\u03fc\\\u03fd\\\u03fe\\\u03ff\\\u0400\\\u0401\\\u0402\\\u0403\\\u0404\\\u0405\\\u0406\\\u0407\\\u0408\\\u0409\\\u040a\\\u040b\\\u040c\\\u040d\\\u040e\\\u040f\\\u0410\\\u0411\\\u0412\\\u0413\\\u0414\\\u0415\\\u0416\\\u0417\\\u0418\\\u0419\\\u041a\\\u041b\\\u041c\\\u041d\\\u041e\\\u041f\\\u0420\\\u0421\\\u0422\\\u0423\\\u0424\\\u0425\\\u0426\\\u0427\\\u0428\\\u0429\\\u042a\\\u042b\\\u042c\\\u042d\\\u042e\\\u042f\\\u0430\\\u0431\\\u0432\\\u0433\\\u0434\\\u0435\\\u0436\\\u0437\\\u0438\\\u0439\\\u043a\\\u043b\\\u043c\\\u043d\\\u043e\\\u043f\\\u0440\\\u0441\\\u0442\\\u0443\\\u0444\\\u0445\\\u0446\\\u0447\\\u0448\\\u0449\\\u044a\\\u044b\\\u044c\\\u044d\\\u044e\\\u044f\\\u0450\\\u0451\\\u0452\\\u0453\\\u0454\\\u0455\\\u0456\\\u0457\\\u0458\\\u0459\\\u045a\\\u045b\\\u045c\\\u045d\\\u045e\\\u045f\\\u0460\\\u0461\\\u0462\\\u0463\\\u0464\\\u0465\\\u0466\\\u0467\\\u0468\\\u0469\\\u046a\\\u046b\\\u046c\\\u046d\\\u046e\\\u046f\\\u0470\\\u0471\\\u0472\\\u0473\\\u0474\\\u0475\\\u0476\\\u0477\\\u0478\\\u0479\\\u047a\\\u047b\\\u047c\\\u047d\\\u047e\\\u047f\\\u0480\\\u0481\\\u0482\\\u0483\\\u0484\\\u0485\\\u0486\\\u0487\\\u0488\\\u0489\\\u048a\\\u048b\\\u048c\\\u048d\\\u048e\\\u048f\\\u0490\\\u0491\\\u0492\\\u0493\\\u0494\\\u0495\\\u0496\\\u0497\\\u0498\\\u0499\\\u049a\\\u049b\\\u049c\\\u049d\\\u049e\\\u049f\\\u04a0\\\u04a1\\\u04a2\\\u04a3\\\u04a4\\\u04a5\\\u04a6\\\u04a7\\\u04a8\\\u04a9\\\u04aa\\\u04ab\\\u04ac\\\u04ad\\\u04ae\\\u04af\\\u04b0\\\u04b1\\\u04b2\\\u04b3\\\u04b4\\\u04b5\\\u04b6\\\u04b7\\\u04b8\\\u04b9\\\u04ba\\\u04bb\\\u04bc\\\u04bd\\\u04be\\\u04bf\\\u04c0\\\u04c1\\\u04c2\\\u04c3\\\u04c4\\\u04c5\\\u04c6\\\u04c7\\\u04c8\\\u04c9\\\u04ca\\\u04cb\\\u04cc\\\u04cd\\\u04ce\\\u04cf\\\u04d0\\\u04d1\\\u04d2\\\u04d3\\\u04d4\\\u04d5\\\u04d6\\\u04d7\\\u04d8\\\u04d9\\\u04da\\\u04db\\\u04dc\\\u04dd\\\u04de\\\u04df\\\u04e0\\\u04e1\\\u04e2\\\u04e3\\\u04e4\\\u04e5\\\u04e6\\\u04e7\\\u04e8\\\u04e9\\\u04ea\\\u04eb\\\u04ec\\\u04ed\\\u04ee\\\u04ef\\\u04f0\\\u04f1\\\u04f2\\\u04f3\\\u04f4\\\u04f5\\\u04f6\\\u04f7\\\u04f8\\\u04f9\\\u04fa\\\u04fb\\\u04fc\\\u04fd\\\u04fe\\\u04ff\\\u0500\\\u0501\\\u0502\\\u0503\\\u0504\\\u0505\\\u0506\\\u0507\\\u0508\\\u0509\\\u050a\\\u050b\\\u050c\\\u050d\\\u050e\\\u050f\\\u0510\\\u0511\\\u0512\\\u0513\\\u0514\\\u0515\\\u0516\\\u0517\\\u0518\\\u0519\\\u051a\\\u051b\\\u051c\\\u051d\\\u051e\\\u051f\\\u0520\\\u0521\\\u0522\\\u0523\\\u0524\\\u0525\\\u0531\\\u0532\\\u0533\\\u0534\\\u0535\\\u0536\\\u0537\\\u0538\\\u0539\\\u053a\\\u053b\\\u053c\\\u053d\\\u053e\\\u053f\\\u0540\\\u0541\\\u0542\\\u0543\\\u0544\\\u0545\\\u0546\\\u0547\\\u0548\\\u0549\\\u054a\\\u054b\\\u054c\\\u054d\\\u054e\\\u054f\\\u0550\\\u0551\\\u0552\\\u0553\\\u0554\\\u0555\\\u0556\\\u0559\\\u055a\\\u055b\\\u055c\\\u055d\\\u055e\\\u055f\\\u0561\\\u0562\\\u0563\\\u0564\\\u0565\\\u0566\\\u0567\\\u0568\\\u0569\\\u056a\\\u056b\\\u056c\\\u056d\\\u056e\\\u056f\\\u0570\\\u0571\\\u0572\\\u0573\\\u0574\\\u0575\\\u0576\\\u0577\\\u0578\\\u0579\\\u057a\\\u057b\\\u057c\\\u057d\\\u057e\\\u057f\\\u0580\\\u0581\\\u0582\\\u0583\\\u0584\\\u0585\\\u0586\\\u0587\\\u0589\\\u058a\\\u0591\\\u0592\\\u0593\\\u0594\\\u0595\\\u0596\\\u0597\\\u0598\\\u0599\\\u059a\\\u059b\\\u059c\\\u059d\\\u059e\\\u059f\\\u05a0\\\u05a1\\\u05a2\\\u05a3\\\u05a4\\\u05a5\\\u05a6\\\u05a7\\\u05a8\\\u05a9\\\u05aa\\\u05ab\\\u05ac\\\u05ad\\\u05ae\\\u05af\\\u05b0\\\u05b1\\\u05b2\\\u05b3\\\u05b4\\\u05b5\\\u05b6\\\u05b7\\\u05b8\\\u05b9\\\u05ba\\\u05bb\\\u05bc\\\u05bd\\\u05be\\\u05bf\\\u05c0\\\u05c1\\\u05c2\\\u05c3\\\u05c4\\\u05c5\\\u05c6\\\u05c7\\\u05d0\\\u05d1\\\u05d2\\\u05d3\\\u05d4\\\u05d5\\\u05d6\\\u05d7\\\u05d8\\\u05d9\\\u05da\\\u05db\\\u05dc\\\u05dd\\\u05de\\\u05df\\\u05e0\\\u05e1\\\u05e2\\\u05e3\\\u05e4\\\u05e5\\\u05e6\\\u05e7\\\u05e8\\\u05e9\\\u05ea\\\u05f0\\\u05f1\\\u05f2\\\u05f3\\\u05f4\\\u0606\\\u0607\\\u0608\\\u0609\\\u060a\\\u060b\\\u060c\\\u060d\\\u060e\\\u060f\\\u0610\\\u0611\\\u0612\\\u0613\\\u0614\\\u0615\\\u0616\\\u0617\\\u0618\\\u0619\\\u061a\\\u061b\\\u061e\\\u061f\\\u0621\\\u0622\\\u0623\\\u0624\\\u0625\\\u0626\\\u0627\\\u0628\\\u0629\\\u062a\\\u062b\\\u062c\\\u062d\\\u062e\\\u062f\\\u0630\\\u0631\\\u0632\\\u0633\\\u0634\\\u0635\\\u0636\\\u0637\\\u0638\\\u0639\\\u063a\\\u063b\\\u063c\\\u063d\\\u063e\\\u063f\\\u0640\\\u0641\\\u0642\\\u0643\\\u0644\\\u0645\\\u0646\\\u0647\\\u0648\\\u0649\\\u064a\\\u064b\\\u064c\\\u064d\\\u064e\\\u064f\\\u0650\\\u0651\\\u0652\\\u0653\\\u0654\\\u0655\\\u0656\\\u0657\\\u0658\\\u0659\\\u065a\\\u065b\\\u065c\\\u065d\\\u065e\\\u0660\\\u0661\\\u0662\\\u0663\\\u0664\\\u0665\\\u0666\\\u0667\\\u0668\\\u0669\\\u066a\\\u066b\\\u066c\\\u066d\\\u066e\\\u066f\\\u0670\\\u0671\\\u0672\\\u0673\\\u0674\\\u0675\\\u0676\\\u0677\\\u0678\\\u0679\\\u067a\\\u067b\\\u067c\\\u067d\\\u067e\\\u067f\\\u0680\\\u0681\\\u0682\\\u0683\\\u0684\\\u0685\\\u0686\\\u0687\\\u0688\\\u0689\\\u068a\\\u068b\\\u068c\\\u068d\\\u068e\\\u068f\\\u0690\\\u0691\\\u0692\\\u0693\\\u0694\\\u0695\\\u0696\\\u0697\\\u0698\\\u0699\\\u069a\\\u069b\\\u069c\\\u069d\\\u069e\\\u069f\\\u06a0\\\u06a1\\\u06a2\\\u06a3\\\u06a4\\\u06a5\\\u06a6\\\u06a7\\\u06a8\\\u06a9\\\u06aa\\\u06ab\\\u06ac\\\u06ad\\\u06ae\\\u06af\\\u06b0\\\u06b1\\\u06b2\\\u06b3\\\u06b4\\\u06b5\\\u06b6\\\u06b7\\\u06b8\\\u06b9\\\u06ba\\\u06bb\\\u06bc\\\u06bd\\\u06be\\\u06bf\\\u06c0\\\u06c1\\\u06c2\\\u06c3\\\u06c4\\\u06c5\\\u06c6\\\u06c7\\\u06c8\\\u06c9\\\u06ca\\\u06cb\\\u06cc\\\u06cd\\\u06ce\\\u06cf\\\u06d0\\\u06d1\\\u06d2\\\u06d3\\\u06d4\\\u06d5\\\u06d6\\\u06d7\\\u06d8\\\u06d9\\\u06da\\\u06db\\\u06dc\\\u06de\\\u06df\\\u06e0\\\u06e1\\\u06e2\\\u06e3\\\u06e4\\\u06e5\\\u06e6\\\u06e7\\\u06e8\\\u06e9\\\u06ea\\\u06eb\\\u06ec\\\u06ed\\\u06ee\\\u06ef\\\u06f0\\\u06f1\\\u06f2\\\u06f3\\\u06f4\\\u06f5\\\u06f6\\\u06f7\\\u06f8\\\u06f9\\\u06fa\\\u06fb\\\u06fc\\\u06fd\\\u06fe\\\u06ff\\\u0700\\\u0701\\\u0702\\\u0703\\\u0704\\\u0705\\\u0706\\\u0707\\\u0708\\\u0709\\\u070a\\\u070b\\\u070c\\\u070d\\\u0710\\\u0711\\\u0712\\\u0713\\\u0714\\\u0715\\\u0716\\\u0717\\\u0718\\\u0719\\\u071a\\\u071b\\\u071c\\\u071d\\\u071e\\\u071f\\\u0720\\\u0721\\\u0722\\\u0723\\\u0724\\\u0725\\\u0726\\\u0727\\\u0728\\\u0729\\\u072a\\\u072b\\\u072c\\\u072d\\\u072e\\\u072f\\\u0730\\\u0731\\\u0732\\\u0733\\\u0734\\\u0735\\\u0736\\\u0737\\\u0738\\\u0739\\\u073a\\\u073b\\\u073c\\\u073d\\\u073e\\\u073f\\\u0740\\\u0741\\\u0742\\\u0743\\\u0744\\\u0745\\\u0746\\\u0747\\\u0748\\\u0749\\\u074a\\\u074d\\\u074e\\\u074f\\\u0750\\\u0751\\\u0752\\\u0753\\\u0754\\\u0755\\\u0756\\\u0757\\\u0758\\\u0759\\\u075a\\\u075b\\\u075c\\\u075d\\\u075e\\\u075f\\\u0760\\\u0761\\\u0762\\\u0763\\\u0764\\\u0765\\\u0766\\\u0767\\\u0768\\\u0769\\\u076a\\\u076b\\\u076c\\\u076d\\\u076e\\\u076f\\\u0770\\\u0771\\\u0772\\\u0773\\\u0774\\\u0775\\\u0776\\\u0777\\\u0778\\\u0779\\\u077a\\\u077b\\\u077c\\\u077d\\\u077e\\\u077f\\\u0780\\\u0781\\\u0782\\\u0783\\\u0784\\\u0785\\\u0786\\\u0787\\\u0788\\\u0789\\\u078a\\\u078b\\\u078c\\\u078d\\\u078e\\\u078f\\\u0790\\\u0791\\\u0792\\\u0793\\\u0794\\\u0795\\\u0796\\\u0797\\\u0798\\\u0799\\\u079a\\\u079b\\\u079c\\\u079d\\\u079e\\\u079f\\\u07a0\\\u07a1\\\u07a2\\\u07a3\\\u07a4\\\u07a5\\\u07a6\\\u07a7\\\u07a8\\\u07a9\\\u07aa\\\u07ab\\\u07ac\\\u07ad\\\u07ae\\\u07af\\\u07b0\\\u07b1\\\u07c0\\\u07c1\\\u07c2\\\u07c3\\\u07c4\\\u07c5\\\u07c6\\\u07c7\\\u07c8\\\u07c9\\\u07ca\\\u07cb\\\u07cc\\\u07cd\\\u07ce\\\u07cf\\\u07d0\\\u07d1\\\u07d2\\\u07d3\\\u07d4\\\u07d5\\\u07d6\\\u07d7\\\u07d8\\\u07d9\\\u07da\\\u07db\\\u07dc\\\u07dd\\\u07de\\\u07df\\\u07e0\\\u07e1\\\u07e2\\\u07e3\\\u07e4\\\u07e5\\\u07e6\\\u07e7\\\u07e8\\\u07e9\\\u07ea\\\u07eb\\\u07ec\\\u07ed\\\u07ee\\\u07ef\\\u07f0\\\u07f1\\\u07f2\\\u07f3\\\u07f4\\\u07f5\\\u07f6\\\u07f7\\\u07f8\\\u07f9\\\u07fa\\\u0800\\\u0801\\\u0802\\\u0803\\\u0804\\\u0805\\\u0806\\\u0807\\\u0808\\\u0809\\\u080a\\\u080b\\\u080c\\\u080d\\\u080e\\\u080f\\\u0810\\\u0811\\\u0812\\\u0813\\\u0814\\\u0815\\\u0816\\\u0817\\\u0818\\\u0819\\\u081a\\\u081b\\\u081c\\\u081d\\\u081e\\\u081f\\\u0820\\\u0821\\\u0822\\\u0823\\\u0824\\\u0825\\\u0826\\\u0827\\\u0828\\\u0829\\\u082a\\\u082b\\\u082c\\\u082d\\\u0830\\\u0831\\\u0832\\\u0833\\\u0834\\\u0835\\\u0836\\\u0837\\\u0838\\\u0839\\\u083a\\\u083b\\\u083c\\\u083d\\\u083e\\\u0900\\\u0901\\\u0902\\\u0903\\\u0904\\\u0905\\\u0906\\\u0907\\\u0908\\\u0909\\\u090a\\\u090b\\\u090c\\\u090d\\\u090e\\\u090f\\\u0910\\\u0911\\\u0912\\\u0913\\\u0914\\\u0915\\\u0916\\\u0917\\\u0918\\\u0919\\\u091a\\\u091b\\\u091c\\\u091d\\\u091e\\\u091f\\\u0920\\\u0921\\\u0922\\\u0923\\\u0924\\\u0925\\\u0926\\\u0927\\\u0928\\\u0929\\\u092a\\\u092b\\\u092c\\\u092d\\\u092e\\\u092f\\\u0930\\\u0931\\\u0932\\\u0933\\\u0934\\\u0935\\\u0936\\\u0937\\\u0938\\\u0939\\\u093c\\\u093d\\\u093e\\\u093f\\\u0940\\\u0941\\\u0942\\\u0943\\\u0944\\\u0945\\\u0946\\\u0947\\\u0948\\\u0949\\\u094a\\\u094b\\\u094c\\\u094d\\\u094e\\\u0950\\\u0951\\\u0952\\\u0953\\\u0954\\\u0955\\\u0958\\\u0959\\\u095a\\\u095b\\\u095c\\\u095d\\\u095e\\\u095f\\\u0960\\\u0961\\\u0962\\\u0963\\\u0964\\\u0965\\\u0966\\\u0967\\\u0968\\\u0969\\\u096a\\\u096b\\\u096c\\\u096d\\\u096e\\\u096f\\\u0970\\\u0971\\\u0972\\\u0979\\\u097a\\\u097b\\\u097c\\\u097d\\\u097e\\\u097f\\\u0981\\\u0982\\\u0983\\\u0985\\\u0986\\\u0987\\\u0988\\\u0989\\\u098a\\\u098b\\\u098c\\\u098f\\\u0990\\\u0993\\\u0994\\\u0995\\\u0996\\\u0997\\\u0998\\\u0999\\\u099a\\\u099b\\\u099c\\\u099d\\\u099e\\\u099f\\\u09a0\\\u09a1\\\u09a2\\\u09a3\\\u09a4\\\u09a5\\\u09a6\\\u09a7\\\u09a8\\\u09aa\\\u09ab\\\u09ac\\\u09ad\\\u09ae\\\u09af\\\u09b0\\\u09b2\\\u09b6\\\u09b7\\\u09b8\\\u09b9\\\u09bc\\\u09bd\\\u09be\\\u09bf\\\u09c0\\\u09c1\\\u09c2\\\u09c3\\\u09c4\\\u09c7\\\u09c8\\\u09cb\\\u09cc\\\u09cd\\\u09ce\\\u09d7\\\u09dc\\\u09dd\\\u09df\\\u09e0\\\u09e1\\\u09e2\\\u09e3\\\u09e6\\\u09e7\\\u09e8\\\u09e9\\\u09ea\\\u09eb\\\u09ec\\\u09ed\\\u09ee\\\u09ef\\\u09f0\\\u09f1\\\u09f2\\\u09f3\\\u09f4\\\u09f5\\\u09f6\\\u09f7\\\u09f8\\\u09f9\\\u09fa\\\u09fb\\\u0a01\\\u0a02\\\u0a03\\\u0a05\\\u0a06\\\u0a07\\\u0a08\\\u0a09\\\u0a0a\\\u0a0f\\\u0a10\\\u0a13\\\u0a14\\\u0a15\\\u0a16\\\u0a17\\\u0a18\\\u0a19\\\u0a1a\\\u0a1b\\\u0a1c\\\u0a1d\\\u0a1e\\\u0a1f\\\u0a20\\\u0a21\\\u0a22\\\u0a23\\\u0a24\\\u0a25\\\u0a26\\\u0a27\\\u0a28\\\u0a2a\\\u0a2b\\\u0a2c\\\u0a2d\\\u0a2e\\\u0a2f\\\u0a30\\\u0a32\\\u0a33\\\u0a35\\\u0a36\\\u0a38\\\u0a39\\\u0a3c\\\u0a3e\\\u0a3f\\\u0a40\\\u0a41\\\u0a42\\\u0a47\\\u0a48\\\u0a4b\\\u0a4c\\\u0a4d\\\u0a51\\\u0a59\\\u0a5a\\\u0a5b\\\u0a5c\\\u0a5e\\\u0a66\\\u0a67\\\u0a68\\\u0a69\\\u0a6a\\\u0a6b\\\u0a6c\\\u0a6d\\\u0a6e\\\u0a6f\\\u0a70\\\u0a71\\\u0a72\\\u0a73\\\u0a74\\\u0a75\\\u0a81\\\u0a82\\\u0a83\\\u0a85\\\u0a86\\\u0a87\\\u0a88\\\u0a89\\\u0a8a\\\u0a8b\\\u0a8c\\\u0a8d\\\u0a8f\\\u0a90\\\u0a91\\\u0a93\\\u0a94\\\u0a95\\\u0a96\\\u0a97\\\u0a98\\\u0a99\\\u0a9a\\\u0a9b\\\u0a9c\\\u0a9d\\\u0a9e\\\u0a9f\\\u0aa0\\\u0aa1\\\u0aa2\\\u0aa3\\\u0aa4\\\u0aa5\\\u0aa6\\\u0aa7\\\u0aa8\\\u0aaa\\\u0aab\\\u0aac\\\u0aad\\\u0aae\\\u0aaf\\\u0ab0\\\u0ab2\\\u0ab3\\\u0ab5\\\u0ab6\\\u0ab7\\\u0ab8\\\u0ab9\\\u0abc\\\u0abd\\\u0abe\\\u0abf\\\u0ac0\\\u0ac1\\\u0ac2\\\u0ac3\\\u0ac4\\\u0ac5\\\u0ac7\\\u0ac8\\\u0ac9\\\u0acb\\\u0acc\\\u0acd\\\u0ad0\\\u0ae0\\\u0ae1\\\u0ae2\\\u0ae3\\\u0ae6\\\u0ae7\\\u0ae8\\\u0ae9\\\u0aea\\\u0aeb\\\u0aec\\\u0aed\\\u0aee\\\u0aef\\\u0af1\\\u0b01\\\u0b02\\\u0b03\\\u0b05\\\u0b06\\\u0b07\\\u0b08\\\u0b09\\\u0b0a\\\u0b0b\\\u0b0c\\\u0b0f\\\u0b10\\\u0b13\\\u0b14\\\u0b15\\\u0b16\\\u0b17\\\u0b18\\\u0b19\\\u0b1a\\\u0b1b\\\u0b1c\\\u0b1d\\\u0b1e\\\u0b1f\\\u0b20\\\u0b21\\\u0b22\\\u0b23\\\u0b24\\\u0b25\\\u0b26\\\u0b27\\\u0b28\\\u0b2a\\\u0b2b\\\u0b2c\\\u0b2d\\\u0b2e\\\u0b2f\\\u0b30\\\u0b32\\\u0b33\\\u0b35\\\u0b36\\\u0b37\\\u0b38\\\u0b39\\\u0b3c\\\u0b3d\\\u0b3e\\\u0b3f\\\u0b40\\\u0b41\\\u0b42\\\u0b43\\\u0b44\\\u0b47\\\u0b48\\\u0b4b\\\u0b4c\\\u0b4d\\\u0b56\\\u0b57\\\u0b5c\\\u0b5d\\\u0b5f\\\u0b60\\\u0b61\\\u0b62\\\u0b63\\\u0b66\\\u0b67\\\u0b68\\\u0b69\\\u0b6a\\\u0b6b\\\u0b6c\\\u0b6d\\\u0b6e\\\u0b6f\\\u0b70\\\u0b71\\\u0b82\\\u0b83\\\u0b85\\\u0b86\\\u0b87\\\u0b88\\\u0b89\\\u0b8a\\\u0b8e\\\u0b8f\\\u0b90\\\u0b92\\\u0b93\\\u0b94\\\u0b95\\\u0b99\\\u0b9a\\\u0b9c\\\u0b9e\\\u0b9f\\\u0ba3\\\u0ba4\\\u0ba8\\\u0ba9\\\u0baa\\\u0bae\\\u0baf\\\u0bb0\\\u0bb1\\\u0bb2\\\u0bb3\\\u0bb4\\\u0bb5\\\u0bb6\\\u0bb7\\\u0bb8\\\u0bb9\\\u0bbe\\\u0bbf\\\u0bc0\\\u0bc1\\\u0bc2\\\u0bc6\\\u0bc7\\\u0bc8\\\u0bca\\\u0bcb\\\u0bcc\\\u0bcd\\\u0bd0\\\u0bd7\\\u0be6\\\u0be7\\\u0be8\\\u0be9\\\u0bea\\\u0beb\\\u0bec\\\u0bed\\\u0bee\\\u0bef\\\u0bf0\\\u0bf1\\\u0bf2\\\u0bf3\\\u0bf4\\\u0bf5\\\u0bf6\\\u0bf7\\\u0bf8\\\u0bf9\\\u0bfa\\\u0c01\\\u0c02\\\u0c03\\\u0c05\\\u0c06\\\u0c07\\\u0c08\\\u0c09\\\u0c0a\\\u0c0b\\\u0c0c\\\u0c0e\\\u0c0f\\\u0c10\\\u0c12\\\u0c13\\\u0c14\\\u0c15\\\u0c16\\\u0c17\\\u0c18\\\u0c19\\\u0c1a\\\u0c1b\\\u0c1c\\\u0c1d\\\u0c1e\\\u0c1f\\\u0c20\\\u0c21\\\u0c22\\\u0c23\\\u0c24\\\u0c25\\\u0c26\\\u0c27\\\u0c28\\\u0c2a\\\u0c2b\\\u0c2c\\\u0c2d\\\u0c2e\\\u0c2f\\\u0c30\\\u0c31\\\u0c32\\\u0c33\\\u0c35\\\u0c36\\\u0c37\\\u0c38\\\u0c39\\\u0c3d\\\u0c3e\\\u0c3f\\\u0c40\\\u0c41\\\u0c42\\\u0c43\\\u0c44\\\u0c46\\\u0c47\\\u0c48\\\u0c4a\\\u0c4b\\\u0c4c\\\u0c4d\\\u0c55\\\u0c56\\\u0c58\\\u0c59\\\u0c60\\\u0c61\\\u0c62\\\u0c63\\\u0c66\\\u0c67\\\u0c68\\\u0c69\\\u0c6a\\\u0c6b\\\u0c6c\\\u0c6d\\\u0c6e\\\u0c6f\\\u0c78\\\u0c79\\\u0c7a\\\u0c7b\\\u0c7c\\\u0c7d\\\u0c7e\\\u0c7f\\\u0c82\\\u0c83\\\u0c85\\\u0c86\\\u0c87\\\u0c88\\\u0c89\\\u0c8a\\\u0c8b\\\u0c8c\\\u0c8e\\\u0c8f\\\u0c90\\\u0c92\\\u0c93\\\u0c94\\\u0c95\\\u0c96\\\u0c97\\\u0c98\\\u0c99\\\u0c9a\\\u0c9b\\\u0c9c\\\u0c9d\\\u0c9e\\\u0c9f\\\u0ca0\\\u0ca1\\\u0ca2\\\u0ca3\\\u0ca4\\\u0ca5\\\u0ca6\\\u0ca7\\\u0ca8\\\u0caa\\\u0cab\\\u0cac\\\u0cad\\\u0cae\\\u0caf\\\u0cb0\\\u0cb1\\\u0cb2\\\u0cb3\\\u0cb5\\\u0cb6\\\u0cb7\\\u0cb8\\\u0cb9\\\u0cbc\\\u0cbd\\\u0cbe\\\u0cbf\\\u0cc0\\\u0cc1\\\u0cc2\\\u0cc3\\\u0cc4\\\u0cc6\\\u0cc7\\\u0cc8\\\u0cca\\\u0ccb\\\u0ccc\\\u0ccd\\\u0cd5\\\u0cd6\\\u0cde\\\u0ce0\\\u0ce1\\\u0ce2\\\u0ce3\\\u0ce6\\\u0ce7\\\u0ce8\\\u0ce9\\\u0cea\\\u0ceb\\\u0cec\\\u0ced\\\u0cee\\\u0cef\\\u0cf1\\\u0cf2\\\u0d02\\\u0d03\\\u0d05\\\u0d06\\\u0d07\\\u0d08\\\u0d09\\\u0d0a\\\u0d0b\\\u0d0c\\\u0d0e\\\u0d0f\\\u0d10\\\u0d12\\\u0d13\\\u0d14\\\u0d15\\\u0d16\\\u0d17\\\u0d18\\\u0d19\\\u0d1a\\\u0d1b\\\u0d1c\\\u0d1d\\\u0d1e\\\u0d1f\\\u0d20\\\u0d21\\\u0d22\\\u0d23\\\u0d24\\\u0d25\\\u0d26\\\u0d27\\\u0d28\\\u0d2a\\\u0d2b\\\u0d2c\\\u0d2d\\\u0d2e\\\u0d2f\\\u0d30\\\u0d31\\\u0d32\\\u0d33\\\u0d34\\\u0d35\\\u0d36\\\u0d37\\\u0d38\\\u0d39\\\u0d3d\\\u0d3e\\\u0d3f\\\u0d40\\\u0d41\\\u0d42\\\u0d43\\\u0d44\\\u0d46\\\u0d47\\\u0d48\\\u0d4a\\\u0d4b\\\u0d4c\\\u0d4d\\\u0d57\\\u0d60\\\u0d61\\\u0d62\\\u0d63\\\u0d66\\\u0d67\\\u0d68\\\u0d69\\\u0d6a\\\u0d6b\\\u0d6c\\\u0d6d\\\u0d6e\\\u0d6f\\\u0d70\\\u0d71\\\u0d72\\\u0d73\\\u0d74\\*(?<![\\ \\\xa0\\\u1680\\\u180e\\\u2000\\\u2001\\\u2002\\\u2003\\\u2004\\\u2005\\\u2006\\\u2007\\\u2008\\\u2009\\\u200a\\\u202f\\\u205f\\\u3000])$' (HTTP 400) (Request-ID: req-7905c1ff-8f28-409a-a1d6-546697dafae2)

IMO, this message needs to be short and appropriate. This error is also logged in nova-api logs and any one can easily flood the logs by sending multiple requests to consume disk space.

NOTE:
I have trimmed 95% error message as I am not able to paste all.

[Takashi Natsume (natsume-takashi)]

I could reproduce in master(commit 5c8edcc6973191a44a83da19d8b8ee6486684809).

[Sean Dague (sdague)]

Have we figured out if this is on the client or the server?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/280814

[Sean Dague (sdague)]

This is definitely an issue on the server, and the impact is a 2MB dump over the network and in the logs.

I think in talking with Alex we came up with a 2 part approach.

Part 1 - make the regex smaller using ranges. That's 280814 above.

Part 2 - provide a more reasonable error which doesn't just barf up the regex, because that regex is not going to mean anything to anyone. As seen by the fact that we build it programatically and it's not even a const.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281143

[Ravi Shekhar Jethani (ravishekar-jethani)]

After analysis on master branch it is found that there are many cases where the user will get very long and cryptic error messages.
There are approx. 92 regex validation related error messages possible out of which approx. 34 can be very long.
For detailed statistics kindly see: https://docs.google.com/spreadsheets/d/1drXA40swkDkmnlaqOWvIL6OffcRPj4w5ZYM8ZMoD3xM/edit?usp=docslist_api

[Ravi Shekhar Jethani (ravishekar-jethani)]

In addition to the solutions proposed another solution would be to:

Truncate the regex part of the message to 256(or something else) characters

Limit the no. of characters in ex.message(https://github.com/openstack/nova/blob/master/nova/api/validation/validators.py#L172) to 256.
All the extra characters after the limit are truncated to '...'
We can do something like:

diff --git a/nova/api/validation/validators.py b/nova/api/validation/validators.py
index 2ae5dfe..270089d 100644
--- a/nova/api/validation/validators.py
+++ b/nova/api/validation/validators.py
@@ -31,6 +31,9 @@ from nova import exception
 from nova.i18n import _

+MAX_MESSAGE_LENGTH = 256
+
+
 @jsonschema.FormatChecker.cls_checks('date-time')
 def _validate_datetime_format(instance):
     try:
@@ -163,16 +166,22 @@ class _SchemaValidator(object):
         try:
             self.validator.validate(*args, **kwargs)
         except jsonschema.ValidationError as ex:
+ msg = ex.message
+ # Error messages can be very long and cryptic because of the
+ # embeded regex pattern. So put a limit on the message length.
+ # Refer https://bugs.launchpad.net/nova/+bug/1541691
+ if len(ex.message) > MAX_MESSAGE_LENGTH:
+ msg = "{0}...".format(ex.message[:MAX_MESSAGE_LENGTH])
             # NOTE: For whole OpenStack message consistency, this error
             # message has been written as the similar format of WSME.
             if len(ex.path) > 0:
                 detail = _("Invalid input for field/attribute %(path)s."
                            " Value: %(value)s. %(message)s") % {
                                'path': ex.path.pop(), 'value': ex.instance,
- 'message': ex.message
+ 'message': msg
                            }
             else:
- detail = ex.message
+ detail = msg
             raise exception.ValidationError(detail=detail)

Example output:

$ nova boot --flavor 1 --image 21ef6ba1-1d71-42af-87a1-94216eb20217 "test "
ERROR (BadRequest): Invalid input for field/attribute name. Value: test . u'test ' does not match u'^(?![\\ \\\xa0\\\u1680\\\u180e\\\u2000\\\u2001\\\u2002\\\u2003\\\u2004\\\u2005\\\u2006\\\u2007\\\u2008\\\u2009\\\u200a\\\u202f\\\u205f\\\u3000])[\\ \\!\\"\\#\\$\\%\\&\\\'\\(\\)\\*\\+\\,\\-\\.\\/0123456789\\:\\;\\<\\=\\>\\?\\@A... (HTTP 400) (Request-ID: req-0a745169-f33e-4e13-aedd-e7160080e250)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280814
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f467af7c55af7807603e77effd709a53fba9b8dd
Submitter: Jenkins
Branch: master

commit f467af7c55af7807603e77effd709a53fba9b8dd
Author: Sean Dague <email address hidden>
Date: Tue Feb 16 11:45:47 2016 -0500

    build smaller name regexes for validation

    The previous name regexes were built by walking the entire utf8 4 byte
    space and building out a regex with all characters that were
    printable. When dumped over the wire on a validation error this
    creates a nearly 2 MB text string (which is also pushed to the logs).

    We can be smarter and assemble character ranges because a-z in regex
    means all character values between those 2 character positions. This
    makes a validate regex approximately 4% the size of the previous one
    (len 1920 vs. len 54263). It thus mitigates the data dump (though it
    does not really give a more clear message).

    Tests were added to ensure we were building the ranges correctly, as
    this is sufficiently tricky.

    There will be follow up to create a better error message. A few
    additional low level validation tests of the regex themselves were
    added in the process of debugging the exclusion support for cells.

    Change-Id: I1d3cc40928d80b4397756846ab749b8bacf17fc9
    Partial-Bug: #1541691

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/283261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/283261
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=243d543f0fc3071a29052b1edf65a262e10647b8
Submitter: Jenkins
Branch: master

commit 243d543f0fc3071a29052b1edf65a262e10647b8
Author: Sean Dague <email address hidden>
Date: Mon Feb 22 16:16:01 2016 -0500

    add regression test for bug #1541691

    This adds a regression test for the bug where we get a giant wall of
    regex back during a name validation failure.

    It uses expectedFail, so it can be landed before this bug is fixed,
    and enforced once it is.

    Change-Id: Ia3bf0f21a3fb99e617e81d2e0008f67458d6e1c5
    Related-Bug: #1541691

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/281143
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8093549e58e1c2de03e29aefa5bf5d1d71f31324
Submitter: Jenkins
Branch: master

commit 8093549e58e1c2de03e29aefa5bf5d1d71f31324
Author: He Jie Xu <email address hidden>
Date: Wed Feb 17 16:26:19 2016 +0800

    Generate better validation error message when using name regexes

    There are some regexes used in the json-schema for complex string validation.
    When the validation failed, json-schema lib didn't generate a useful error
    info for the user, it shows the regex to the user. But regex is really
    unreadable for normal user. This patch override the default FormatChecker to
    support passed in custom error message. This required using custom format
    checker instead of using 'pattern'.

    Change-Id: Ie6d789e38f64e04a3a76618639c34d36591d6187
    Partial-Bug: #1541691

[Richard Theis (rtheis)]

I think that https://review.openstack.org/#/c/281143/ broke the openstackclient and novaclient aggregate create CLI. Both allowed made the availability zone optional which results in null being passed to the API.

ubuntu@openstackclient:/opt/stack/python-openstackclient$ openstack aggregate create foo
expected string or buffer (HTTP 400) (Request-ID: req-41d146cf-8ce4-4cce-8371-ffe6e03a3c73)
ubuntu@openstackclient:/opt/stack/python-openstackclient$ nova aggregate-create foo
ERROR (BadRequest): expected string or buffer (HTTP 400) (Request-ID: req-57bdcf61-d7d4-4242-98f6-88204ac3869b)

[jichenjc (jichenjc)]

I confirm this can be reproduced

DEBUG (shell:894) expected string or buffer (HTTP 400) (Request-ID: req-aae27e51-e6bb-4e6a-bc14-01c28a699602)
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/novaclient/shell.py", line 892, in main
    OpenStackComputeShell().main(argv)
  File "/usr/local/lib/python2.7/dist-packages/novaclient/shell.py", line 819, in main
    args.func(self.cs, args)
  File "/usr/local/lib/python2.7/dist-packages/novaclient/v2/shell.py", line 3533, in do_aggregate_create
    aggregate = cs.aggregates.create(args.name, args.availability_zone)
  File "/usr/local/lib/python2.7/dist-packages/novaclient/v2/aggregates.py", line 55, in create
    return self._create('/os-aggregates', body, 'aggregate')
  File "/usr/local/lib/python2.7/dist-packages/novaclient/base.py", line 303, in _create
    _resp, body = self.api.client.post(url, body=body)
  File "/usr/local/lib/python2.7/dist-packages/keystoneauth1/adapter.py", line 179, in post
    return self.request(url, 'POST', **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/novaclient/client.py", line 92, in request
    raise exceptions.from_response(resp, body, url, method)
BadRequest: expected string or buffer (HTTP 400) (Request-ID: req-aae27e51-e6bb-4e6a-bc14-01c28a699602)
ERROR (BadRequest): expected string or buffer (HTTP 400) (Request-ID: req-aae27e51-e6bb-4e6a-bc14-01c28a699602)

2016-03-03 14:49:30.190 DEBUG nova.api.openstack.wsgi [req-aae27e51-e6bb-4e6a-bc14-01c28a699602 demo demo] Action: 'create', calling method: <bound method AggregateController.create of <nova.api.openstack.compute.aggregates.AggregateController object at 0x7f2a8301cb50>>, body: {"aggregate": {"name": "foo", "availability_zone": null}} from (pid=3224) _process_stack /opt/stack/nova/nova/api/openstack/wsgi.py:696
2016-03-03 14:49:30.206 DEBUG nova.api.openstack.wsgi [req-aae27e51-e6bb-4e6a-bc14-01c28a699602 demo demo] Returning 400 to user: expected string or buffer from (pid=3224) __call__ /opt/stack/nova/nova/api/openstack/wsgi.py:1070

[jichenjc (jichenjc)]

https://bugs.launchpad.net/nova/+bug/1552888 open this bug since it's different problem

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/288260

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/288260
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=923cf20eca35b551ae1fb4a77835f8104ea6cbed
Submitter: Jenkins
Branch: master

commit 923cf20eca35b551ae1fb4a77835f8104ea6cbed
Author: He Jie Xu <email address hidden>
Date: Wed Feb 17 16:26:19 2016 +0800

    Generate better validation error message when using name regexes

    There are some regexes used in the json-schema for complex string validation.
    When the validation failed, json-schema lib didn't generate a useful error
    info for the user, it shows the regex to the user. But regex is really
    unreadable for normal user. This patch override the default FormatChecker to
    support passed in custom error message. This required using custom format
    checker instead of using 'pattern'.

    For aggregates API, it enabled 'null' in the name input. As the 'format'
    keyword works for all allowed types and name format check will only validate
    string type, so this patch change the schema to use 'oneOf' keyword, then
    the 'format' will only against on string type.

    Change-Id: Ic0e608b8a18b635bfcd936f57f14c9f54e1ef8b4
    Partial-Bug: #1541691

[Markus Zoeller (markus_z) (mzoeller)]

IIUC, this got completely solved with these commits:

* Generate better validation error message when using name regexes
  923cf20eca35b551ae1fb4a77835f8104ea6cbed
* build smaller name regexes for validation
  f467af7c55af7807603e77effd709a53fba9b8dd
* add regression test for bug #1541691
  243d543f0fc3071a29052b1edf65a262e10647b8

I'm going to double-check it on current master (Newton) code.

[Markus Zoeller (markus_z) (mzoeller)]

This is fixed. Re-tested with:

    $ nova boot --flavor m1.tiny --image cirros-0.3.4-x86_64-uec "test "
    ERROR (BadRequest): An invalid 'name' value was provided.
    The name must be: printable characters. Can not start or end with
    whitespace. (HTTP 400)
    (Request-ID: req-6e4cefdf-eca8-4878-98c9-85a6387b6d8f)

Test environment:

    $ ./tools/info.sh
    os|distro=trusty
    os|vendor=Ubuntu
    os|release=14.04
    git|cinder|master[b4b0c96]
    git|devstack|master[be11ae7]
    git|glance|master[6e13a71]
    git|horizon|master[3666072]
    git|keystone|master[6f9f390]
    git|noVNC|master[b403cb9]
    git|nova|[386d45e]

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/306465

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306465
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=72a0a7c174f2ba0787defc10af6f67403a705647
Submitter: Jenkins
Branch: master

commit 72a0a7c174f2ba0787defc10af6f67403a705647
Author: Michal Pryc <email address hidden>
Date: Fri Apr 15 16:16:16 2016 +0200

    Fixes unexpectedly passing functional test.

    This fix allows all functional tests passing rather
    then one unexpectedly passing:

    test_bug_1541691.TestServerValidation.test_name_validation

    The bug 1541691 was merged, however test never got updated.

    Change-Id: I84597ad5f5ca9ef457f34769e3fe299b780acadd
    Closes-Bug: 1570884
    Related-Bug: 1541691

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/306624

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306624
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=aefc17756d3b8f6149c700920385f0a894bb05a2
Submitter: Jenkins
Branch: stable/mitaka

commit aefc17756d3b8f6149c700920385f0a894bb05a2
Author: Michal Pryc <email address hidden>
Date: Fri Apr 15 16:16:16 2016 +0200

    Fixes unexpectedly passing functional test.

    This fix allows all functional tests passing rather
    then one unexpectedly passing:

    test_bug_1541691.TestServerValidation.test_name_validation

    The bug 1541691 was merged, however test never got updated.

    Change-Id: I84597ad5f5ca9ef457f34769e3fe299b780acadd
    Closes-Bug: 1570884
    Related-Bug: 1541691
    (cherry picked from commit 72a0a7c174f2ba0787defc10af6f67403a705647)